Repository navigation
Coverage exclusions: follow the ifu, tlbcontrol and privdec changes - #1989
Closed
davidharrishmc wants to merge 2 commits into
Closed
davidharrishmc wants to merge 2 commits into
davidharrishmc wants to merge 2 commits into
Conversation
regression-wally --ccov stopped at the exclusion step: two GetLineNum patterns still named ~ITLBMissF, which ifu.sv now spells ~ITLBMissOrUpdateRawF. The ITLB TLBMiss exclusion named row 3, but with UpperBitsUnequal added Questa lists TLBAccess_0 as row 5. The wfi rework left two rows of TWTimeoutM uncovered: wfiM_0 can't occur with the wait counter saturated, since the counter clears whenever M advances, so it is excluded; STATUS_TW_0 in S mode is reached by the new wfiSnoTW test, an S-mode wfi with mstatus.TW = 0 that waits past the counter limit for a timer interrupt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Overlap check that invalidates TLB lines overlapping a new entry had rows no test reached on any ITLB or DTLB line: a NAPOT leaf in the line's 64 KiB region or in another region of its megapage, a global leaf under another ASID, and an Sv57 petapage leaf that differs from the line only in VPN[3]. tlbOverlap fills all 32 lines of each TLB with 4 KiB pages before each case, sized to the replacement policy, and checks every access's translation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
A full 🤖 Generated with Claude Code |
davidharrishmc
added a commit
to davidharrishmc/cvw
that referenced
this pull request
Oct 16, 2026
…-remaining Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Folded into #1920 (merge 9276112), so the exclusion fixes and the 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
regression-wally --ccovon main stopped at the exclusion step: twoGetLineNumpatterns still named~ITLBMissF, which #1934 renamed to~ITLBMissOrUpdateRawFinifu.sv. This fixes them, moves the ITLB TLBMiss exclusion from row 3 to row 5 (TLBAccess_0) now that #1928 addedUpperBitsUnequal, excludes the unreachablewfiM_0row ofTWTimeoutMfrom #1941, and addswfiSnoTW.S(an S-mode wfi with mstatus.TW = 0 that waits past the counter limit) to cover the reachableSTATUS_TW_0row. It also addstlbOverlap.S, which reaches the rows of thetlbcamlineOverlap expression (from #1927) that no test hit, on every ITLB and DTLB line. With #1920 merged on top, rv64gc code coverage has no uncovered rows left.🤖 Generated with Claude Code