Skip to content

Added condition to exit MULTI_CYCLE stage on CV-X_IF instruction - #344

Merged
MikeOpenHWGroup merged 1 commit into
openhwfoundation:mainfrom
anecorral:multi_cycle_we
Oct 9, 2026
Merged

MikeOpenHWGroup merged 1 commit into
openhwfoundation:mainfrom
anecorral:multi_cycle_we

Conversation

@anecorral

@anecorral anecorral commented Oct 7, 2026 •

Copy link
Copy Markdown

As discussed on #342.

(cve2_id_stage.sv) Added x_result_i.we condition to assert coproc_done to exit MULTI_CYCLE stage for CV-X-IF instruction expecting writeback.

@MikeOpenHWGroup
MikeOpenHWGroup requested a balanced review from Copilot October 9, 2026 14:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused change correctly addresses issue #342 without introducing unresolved concerns.

0 open findings

🧠 Review effort: Balanced

@MikeOpenHWGroup

Copy link
Copy Markdown

Thanks @anecorral, this looks good and passes our verification regression (with XInterface set to '0). This change will break equivalence, so I have deliberately not launched the workflows.

@MikeOpenHWGroup
MikeOpenHWGroup merged commit 1d532c1 into openhwfoundation:main Oct 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants