Skip to content

fix(PacketDetailsModal): don't let a failed companion lookup discard advert names #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
npdgm wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(PacketDetailsModal): don't let a failed companion lookup discard advert names #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/modals/PacketDetailsModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,9 @@ const refreshContactLookup = async () => {
contactLookupLoading.value = true;
try {
const [contactsResponse, advertResponses] = await Promise.all([
ApiService.get('/companion/contacts'),
// A repeater with no companion bridge returns 503 here; treat it like the
// advert lookups below so advert-based names still resolve.
ApiService.get('/companion/contacts').catch(() => null),
Promise.all(
ADVERT_CONTACT_TYPES.map((contactType) =>
ApiService.get('/adverts_by_contact_type', {
Expand Down