Skip to content

Conversation

@FloPinguin
Copy link
Contributor

Description:

Based on Nikola map lead feedback

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

FloPinguin

@FloPinguin FloPinguin requested a review from a team as a code owner January 3, 2026 15:20
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 3, 2026

Walkthrough

Reduced the largest player tier for GameMapType.Surrounded from 56 to 42 players; mid (28) and small (14) tiers unchanged. Updated inline comment to reflect "3, 2, 1 player(s) per island."

Changes

Cohort / File(s) Summary
Map Player Configuration
src/core/configuration/DefaultConfig.ts
Changed numPlayersConfig[GameMapType.Surrounded] from [56, 28, 14] to [42, 28, 14]. Updated inline comment from "4, 2, 1 players per island" to "3, 2, 1 player(s) per island".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

Balance Tweak

Suggested reviewers

  • evanpelle
  • scottanderson

Poem

🏝️ Three per isle now set to play,
The map trims numbers, clears the way.
Forty-two take the larger ring,
Small and mid keep tethering. 🎲

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adjusting player count configuration for the Surrounded map, which matches the file modification in DefaultConfig.ts.
Description check ✅ Passed The description is related to the changeset, mentioning map lead feedback as the reason for the player count adjustment, and includes the standard checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 39609d4 and e56d527.

📒 Files selected for processing (1)
  • src/core/configuration/DefaultConfig.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/core/configuration/DefaultConfig.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot previously approved these changes Jan 3, 2026
@iiamlewis iiamlewis added the Maps A new map, or adjustments to an existing map itself, its json, etc, label Jan 3, 2026
@iiamlewis iiamlewis added this to the v29 milestone Jan 3, 2026
@iiamlewis iiamlewis moved this from Triage to Final Review in OpenFront Release Management Jan 3, 2026
@evanpelle evanpelle merged commit 6d1e2f5 into openfrontio:main Jan 4, 2026
7 checks passed
@github-project-automation github-project-automation bot moved this from Final Review to Complete in OpenFront Release Management Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maps A new map, or adjustments to an existing map itself, its json, etc,

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants