-
Notifications
You must be signed in to change notification settings - Fork 89
feat(openfga): show ask ai button on mobile #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughChanges modify the "Ask AI" navbar button structure in Docusaurus configuration by removing a wrapper div, simplifying button markup, and updating corresponding CSS styling including responsive layout adjustments for mobile viewport widths. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/css/custom.css (1)
1-1: Address Prettier formatting issues before merging.The pipeline indicates code style issues. Run
npx prettier --write src/css/custom.cssto fix formatting.
🧹 Nitpick comments (1)
src/css/custom.css (1)
84-90: Fragile selector: hashed class name may break on updates.
.navbarSearchContainer_Bca1appears to be a CSS module-generated hash that could change when Docusaurus or@easyops-cn/docusaurus-search-localis updated. Consider using a more stable selector like[class*="navbarSearchContainer"]or adding a custom class to the search component if the plugin supports it.♻️ Suggested more resilient selector
-.navbar__items--right .navbarSearchContainer_Bca1 { +.navbar__items--right [class*="navbarSearchContainer"] { order: 1; }Apply the same pattern to lines 125-131 and 133-136.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docusaurus.config.jssrc/css/custom.css
🧰 Additional context used
🪛 GitHub Actions: Run Checks: Lint, Audit and Build
src/css/custom.css
[warning] 1-1: Code style issues found in the above file. Run Prettier with --write to fix.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: deploy-preview
- GitHub Check: Test deployment
🔇 Additional comments (3)
docusaurus.config.js (1)
274-278: LGTM! Clean simplification of the Ask AI button markup.The removal of the wrapper
<div>in favor of a standalone<button>is a good refactor. TheclassName: 'ask-ai-nav-item'on the navbar item config enables CSS targeting, and the.ask-ai-buttonclass is retained so the Kapa widget selector (line 339) continues to work correctly.src/css/custom.css (2)
44-65: LGTM!The button styling is clean with good use of CSS variables for theming consistency. The
white-space: nowrapaddition ensures the button text stays on a single line across viewports.
92-142: Mobile layout approach is solid.Good use of CSS variable
--ask-ai-mobile-widthfor consistent sizing across multiple rules. The absolute positioning withtransform: translateY(-50%)for vertical centering is a clean approach.Note: The same hashed class concern applies to
.searchBar_RVTson line 133.
Screen.Recording.2026-01-13.at.2.12.41.PM.mov
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.