fix: add missing course filter attribute - #283
Conversation
this is used to delete courses. (cherry picked from commit 1db1bfd)
|
Thanks for the pull request, @johanseto! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
bradenmacdonald
left a comment
There was a problem hiding this comment.
Thank you for this fix! Could you please include a version bump to 7.0.3 in edxsearch/__init__.py ?
Description
This is used to delete courses.
(cherry picked from commit 1db1bfd)
Context & Issue:
Currently, the course deletion functionality is broken. When attempting to delete a course using Meilisearch, the operation fails because the
courseattribute is not configured as a filterable parameter within theCOURSE_INFO_INDEX.Solution:
This PR fixes the issue by adding
courseto the list of filterable attributes for theCOURSE_INFO_INDEXhttps://github.com/openedx/openedx-platform/blob/5439a27f8522d74d63726ec266c0263a3bbfb69b/cms/djangoapps/contentstore/courseware_index.py#L669 , allowing Meilisearch to properly filter and execute the deletion.https://github.com/openedx/openedx-platform/blob/22512ba78be63fc2c6ffe23637b76f31d1aed656/cms/djangoapps/contentstore/signals/handlers.py#L176
Test
Before
After