refactor(supportability): expose LokiClient for external reuse#928
Merged
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
rohan2794
force-pushed
the
expose-loki-client
branch
from
aff975d to
1af0a4d
Compare
Abhinandan-Purkait
approved these changes
Jul 9, 2026
rohan2794
force-pushed
the
expose-loki-client
branch
2 times, most recently
from
c747816 to
cca579b
Compare
tiagolobocastro
approved these changes
Jul 13, 2026
rohan2794
force-pushed
the
expose-loki-client
branch
from
cca579b to
72eac9f
Compare
Make LokiClient and LokiError pub, add fetch_lines() for callers that need a Vec<String> rather than file output, and add with_logql_filters() and with_page_size() builder methods. No behaviour change to existing fetch_and_dump_logs path. Signed-off-by: rohan2794 <rohan2794@gmial.com>
rohan2794
force-pushed
the
expose-loki-client
branch
from
72eac9f to
3c9ce46
Compare
Member
|
bors merge |
bors-openebs-mayastor Bot
pushed a commit
that referenced
this pull request
Jul 13, 2026
928: refactor(supportability): expose LokiClient for external reuse r=abhilashshetty04 a=rohan2794 Make LokiClient and LokiError pub, add fetch_lines() for callers that need a Vec<String> rather than file output, and add with_logql_filters() and with_page_size() builder methods. No behaviour change to existing fetch_and_dump_logs path. Co-authored-by: rohan2794 <rohan2794@gmial.com>
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into develop. It will not be retried. Additional information: Response status code: 422
{"message":"Repository rule violations found\n\nChanges must be made through the merge queue\n\n","documentation_url":"https://docs.github.com/rest/git/refs#update-a-reference","status":"422"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make LokiClient and LokiError pub, add fetch_lines() for callers that need a Vec rather than file output, and add with_logql_filters() and with_page_size() builder methods.
No behaviour change to existing fetch_and_dump_logs path.