fix(datadog): add nil check for NextRecordId in pagination logic (#68)#70
Open
1PoPTRoN wants to merge 1 commit intoopencost:mainfrom
Open
fix(datadog): add nil check for NextRecordId in pagination logic (#68)#701PoPTRoN wants to merge 1 commit intoopencost:mainfrom
1PoPTRoN wants to merge 1 commit intoopencost:mainfrom
Conversation
a2383de to
685416b
Compare
There was a problem hiding this comment.
Pull request overview
This PR hardens the Datadog plugin’s hourly cost pagination loop by preventing a nil-pointer dereference when the Datadog SDK marks NextRecordId as “set” but the underlying pointer returned by .Get() is nil (issue #68).
Changes:
- Add a defensive nil check around
resp.Meta.Pagination.NextRecordId.Get()before dereferencing. - Ensure pagination terminates safely by falling back to an empty
nextPageIdwhen the token is missing or nil.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ost#68) Signed-off-by: 1PoPTRoN <vrxn.arp1traj@gmail.com>
685416b to
543f04a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
NextRecordIdfrom the Datadog API response in the hourly cost retrieval logic.SIGSEGV(segmentation violation) that occurred when the Datadog API returned a "set" optional value for the pagination token that contained anilpointer.Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
go test ./...in thepkg/plugins/datadogdirectory. All existing tests passed successfully.linux/arm64,linux/amd64,darwin/arm64,darwin/amd64) using the project'stools/build-pluginsscript.Nullabletypes.Does this PR require changes to documentation?