Add SMTP attachment support#124
Draft
diesdasjunge wants to merge 1 commit into
Draft
Conversation
|
|
@diesdasjunge is attempting to deploy a commit to the OpenCore Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds attachment support to the built-in SMTP adapter using the existing
EmailAttachmentAPI and sharedattachmentToBytes()helper.SMTP now accepts attachments, builds dependency-free MIME payloads, and becomes a valid fallback route for attachment-bearing messages while continuing to reject unsupported tags and metadata.
What Changed
attachmentsin SMTP field support.multipart/mixedwhen attachments are present.multipart/alternativefor text + HTML bodies.timeoutMsconsideration for large attachments.Verification
bun test packages/email-sdk/src/smtp.test.tsbun test packages/email-sdk/src/cli.test.tsbun test packages/email-sdkbun run check-typesbun run release:ciNotes
tagsandmetadata.Content-ID, but richer inline-image behavior is intentionally not advertised beyond that.timeoutMs.