feat: reject domain client initialization in browsers#5
Open
safwanyp wants to merge 1 commit into
Open
Conversation
|
@safwanyp is attempting to deploy a commit to the OpenCore Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Context
the readme states:
an early exit is not a "silver bullet" or anything, but it helps prevent accidental client-side usage.
Changes
createDomainClient()fails when browser globals such aswindowordocumentare present.i thought about including browser worker detection, but it's tricky.
WorkerGlobalScopeis what i was planning on using, but it can also be present in valid server-side worker runtimes. as far as i know, cloudflare workers (as an exmaple) has worker-style globals. adding a check for this might be risky, so i decided not to include it.