Skip to content

added changes to internal/juniper/juniper.go#37

Open
Swetha-haridasula wants to merge 1 commit intoopenconfig:mainfrom
Swetha-haridasula:internal_juniper
Open

added changes to internal/juniper/juniper.go#37
Swetha-haridasula wants to merge 1 commit intoopenconfig:mainfrom
Swetha-haridasula:internal_juniper

Conversation

@Swetha-haridasula
Copy link

No description provided.

Copy link

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@nsadhasivam nsadhasivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@sezhang2 sezhang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change would cause Juniper QoS failures as only queue id is supported as of now.

@sezhang2
Copy link

Waiting for b/366058210 to be resolved first.

@dplore
Copy link
Member

dplore commented May 8, 2025

@Swetha-haridasula do you intend to pursue this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants