Merged
Conversation
Chounoki
force-pushed
the
pr1
branch
3 times, most recently
from
6703b27 to
2925070
Compare
Chounoki
force-pushed
the
pr1
branch
3 times, most recently
from
201daa9 to
7e43f2a
Compare
gmacf
reviewed
Feb 26, 2026
gmacf
reviewed
Feb 26, 2026
Contributor
|
One last comment: Do you think we need approval on this PR from Chris Fenner? Or if it's basically been copied from his proposal, do we have implicit approval? |
Contributor
Author
I guess that is not really necessary. |
gmacf
approved these changes
Feb 27, 2026
Contributor
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.