feat: add fab to admin settings and spaces overview#2025
Open
AlexAndBear wants to merge 3 commits intomainfrom
Open
feat: add fab to admin settings and spaces overview#2025AlexAndBear wants to merge 3 commits intomainfrom
AlexAndBear wants to merge 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements Floating Action Buttons (FABs) in the admin-settings app and makes the FAB behavior context-sensitive in the files app's spaces overview. The changes consolidate the creation actions for Users, Groups, and Spaces into a single FAB component that adapts based on the current view, following UI/UX consistency requirements from issues #2011 and #2008.
Changes:
- Added FAB extension to admin-settings app with context-aware handler for Users, Groups, and Spaces views
- Made files app FAB context-sensitive: directly creates spaces on the projects overview, shows dropdown menu elsewhere
- Refactored space creation logic into reusable
useSpaceActionsCreatecomposable and addedaddNewSpacetouseCreateSpace
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-runtime/src/components/AppFloatingActionButton.vue | Added mode condition to only render dropComponent when mode is 'drop' |
| packages/web-pkg/src/composables/piniaStores/extensionRegistry/types.ts | Added FloatingActionButtonExtensionMode type and mode property to extension interface |
| packages/web-pkg/src/composables/spaces/useCreateSpace.ts | Added addNewSpace function to handle space creation with store updates and notifications |
| packages/web-pkg/src/composables/actions/spaces/useSpaceActionsCreate.ts | New composable providing space creation action with modal handling |
| packages/web-pkg/src/components/AppBar/CreateSpace.vue | Removed standalone CreateSpace component (replaced by FAB) |
| packages/web-app-files/src/views/spaces/Projects.vue | Removed CreateSpace button and permission check (handled by FAB) |
| packages/web-app-files/src/extensions.ts | Added context-sensitive FAB handler and mode determination for spaces projects |
| packages/web-app-admin-settings/src/index.ts | Added FAB extension with route-based handler switching for Users, Groups, and Spaces |
| packages/web-app-admin-settings/src/views/Users.vue | Removed inline create user button (replaced by FAB) |
| packages/web-app-admin-settings/src/views/Groups.vue | Removed inline create group button (replaced by FAB) |
| packages/web-app-admin-settings/src/views/Spaces.vue | Removed inline create space button (replaced by FAB) |
| tests/e2e/support/objects/app-files/spaces/actions.ts | Updated selector to use FAB class instead of specific button ID |
| tests/e2e/support/objects/app-admin-settings/users/actions.ts | Updated selector to use FAB class instead of specific button ID |
| tests/e2e/support/objects/app-admin-settings/groups/actions.ts | Updated selector to use FAB class instead of specific button ID |
| packages/web-pkg/tests/unit/composables/actions/spaces/useSpaceActionsCreate.spec.ts | New unit test for useSpaceActionsCreate composable |
| packages/web-app-files/tests/unit/views/spaces/Projects.spec.ts | Removed test for CreateSpace button display |
| packages/web-app-admin-settings/tests/unit/views/Users.spec.ts | Removed tests for create user button display |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
be558f8 to
5eddf5d
Compare
# Conflicts: # packages/web-runtime/src/components/AppFloatingActionButton.vue
9edb0e2 to
13bf3fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
How Has This Been Tested?
Types of changes