docs: propose credential lifecycle and GitHub App access - #68
freeqaz-openai wants to merge 18 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 14, 2026, 6:42 PM ET / 22:42 UTC (Revision 17). ClawSweeper reviewWhat this changesAdds a staged Enterprise GitHub access proposal covering repository configuration, protected credentials, scoped proxy credentials, human-approved publication, cleanup, and qualification requirements. Merge readiness⛔ Blocked before merge - 4 items remain This remains a distinct, coherent RFC that is absent from main. No actionable patch defect was found, but the repository requires explicit RFC acceptance before merge. Priority: P3 Review scores
Verification
How this fits togetherOpenClaw Enterprise's proposed credential gateway sits between Agent repository requests and GitHub. It combines administrator-selected access, independently verified execution identity, and current control-plane authorization before using protected provider credentials. flowchart LR
Config[Administrator repository selection] --> Authority[Current control-plane authorization]
Agent[Agent repository request] --> Connector[Trusted execution connector]
Connector --> Gateway[Credential gateway]
Authority --> Gateway
Approval[Human-approved publication candidate] --> Gateway
Gateway --> GitHub[Scoped GitHub operation]
Decision needed
Why: This adds a new configuration and integration direction, and README explicitly reserves RFC acceptance for the repository's discussion and acceptance process. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Accept a clearly staged contract with explicit companion dependencies and implementation evidence gates, keeping production qualification separate from RFC approval. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes future contracts and explicitly claims documentation checks only, rather than reporting a reproducible runtime defect. Is this the best way to solve the issue? Yes, as an RFC: staged delivery, existing authority ownership, and separate production qualification form a coherent design path; acceptance of the new integration contract remains a human decision. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 967d9aac7472. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (16 earlier review cycles; latest 8 shown)
|
What Problem This Solves
Enterprise Agents need repository access whose scope, approvals and cleanup survive turns and runtime replacement. Provider tokens alone cannot enforce an approved candidate, exact branch or original-work attribution.
Why This Change Was Made
Propose native Agent repository configuration and an Installation-selected
CredentialGatewayDriverfor mediation and credential lifecycle. Delivery starts with managed metadata, clone and fetch, then adds selected coding read workflows and exact-candidate Approve and publish. Any configured, authorized human may approve, including the requester; an Agent cannot. Independent-human approval and automatic authorization under explicit policy for bounded, allowlisted push/draft-PR operations are separate later modes. Broader durable Work and lifecycle controls follow the initial root work and subordinate helpers using the same scope.User Impact
The proposed configuration and driver API are not implemented. The proposed GitHub profile keeps provider credentials outside Agent workloads and requires current online OCC authority for reads, writes and credential maintenance. Publication binds the candidate, refs, expected remote tip and PR metadata, preserving separate effect receipts and reconciling unknown outcomes without blind replay. Permission changes require fresh Pod/gVisor isolation; uncapped execution still uses finite leases.
This is a documentation proposal extending RFC 0027. It remains draft with a blank implementation issue pending acceptance.
Reading Guide
Evidence