Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 9, 2026, 7:47 PM ET / 23:47 UTC (Revision 4). ClawSweeper reviewWhat this changesAdds an RFC proposing plugin update notices across CLI inventory, update status, and Control UI, with explicit refresh, preserved pins, and shared retained observations. Merge readiness⛔ Blocked before merge - 4 items remain Keep open: this is a coherent, distinct RFC with no verified merged replacement. Repository lifecycle approval and the prior document-verification request remain outstanding; no actionable patch defect was found. Priority: P3 Review scores
Verification
How this fits togetherThis repository stores OpenClaw design proposals for discussion and acceptance before implementation. The proposed plugin availability view would turn recorded installations and registry metadata into consistent CLI and Control UI notices. flowchart TD
A[Recorded plugin installations] --> C[Proposed metadata resolver]
B[Explicit authorized refresh] --> C
C --> D[Registry metadata]
D --> E[Retained availability observations]
E --> F[CLI inventory and status]
E --> G[Control UI notices]
Decision needed
Why: The repository requires RFC acceptance, and the proposed command, retention policy, and storage ownership need product agreement rather than mechanical correction. Before merge
Agent review detailsSecurityNone. Review metricsNone. Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Adopt a maintainer-approved, source-preserving availability contract that keeps inventory local and distinguishes eligible, pinned, stale, and unknown results. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR proposes a new availability view and refresh flag rather than repairing an established behavior contract. Is this the best way to solve the issue? Yes at the architectural level: sharing metadata resolution while preserving sources and pins avoids competing selection logic; the exact refresh and persistence contract still needs acceptance. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 967d9aac7472. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (3 earlier review cycles) |
What Problem This Solves
Formalizes Erick Kinnee's proposal to surface installed-plugin update availability in CLI inventory, update status, and Control UI.
Related: openclaw/openclaw#131897
Why This Change Was Made
Proposes ClawHub as the primary metadata path while preserving recorded npm sources. Defines explicit plugin refresh, shared SQLite observation ownership, 24-hour freshness, four concurrent lookups, a 15-second network budget, and JSON distinctions for eligible, excluded, stale, and unknown results. Core upgrades invalidate cached eligibility. Metadata checks must not enter installer dry-run paths.
These defaults and persistence semantics are proposed for maintainer acceptance. Exact schema, migration, and publication fencing require storage-owner review before implementation. Upgrade preflight remains separate: openclaw/openclaw#122019.
User Impact
Proposal only; no runtime behavior changes. If accepted and implemented, operators could discover plugin updates while preserving pins and distinguishing incomplete checks.
Evidence
The required maintainer-discussion thread and RFC acceptance remain outstanding. A maintainer sponsor is needed to advance that discussion.