docs: propose demand-driven session sidebar collections - #64
Conversation
Co-authored-by: jesse-merhi <79823012+jesse-merhi@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 12, 2026, 6:46 AM ET / 10:46 UTC (Revision 18). ClawSweeper reviewWhat this changesAdds a draft RFC proposing authoritative sidebar collection summaries and independently paginated session rows loaded according to visible demand. Merge readiness⛔ Blocked before merge - 5 items remain This remains a distinct, coherent design proposal that is absent from current main. Repository policy reserves acceptance for maintainers, and the prior RFC-only proof exception remains unresolved. Priority: P3 Review scores
Verification
How this fits togetherThe proposed Control UI sidebar would receive session membership and attention summaries from the Gateway, then request children for expanded, visible collections. A single virtualized list would turn those results into session navigation; this PR only documents that architecture. flowchart TD
A[Sessions and attention facts] --> B[Gateway collection summaries]
C[Global sidebar filters] --> B
B --> D[Sidebar collection manifest]
D --> E[Expanded and visible collections]
E --> F[Independent child pages]
F --> G[Virtualized session navigation]
Decision needed
Why: The repository lifecycle places implementation after acceptance, while the review contract's automatic documentation exemption only covers docs/ paths. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Accept a bounded collection-read architecture before implementation, with browser and compatibility evidence attached to subsequent implementation slices. Do we have a high-confidence way to reproduce the issue? Not applicable to this documentation patch; the linked report supplies a concrete motivating scenario, but this review did not execute the OpenClaw sidebar. Is this the best way to solve the issue? Yes as a design proposal: independent collection ownership addresses truncated global grouping coherently, while provider contracts and performance budgets appropriately remain acceptance questions. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against 967d9aac7472. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (17 earlier review cycles; latest 8 shown)
|
Related: openclaw/openclaw#126701
Related: openclaw/openclaw#126708
Discussion: https://discord.com/channels/1456350064065904867/1541083365103370340
What Problem This Solves
The Control UI sidebar currently derives heterogeneous groups from a bounded
global session page. An expanded category can therefore look complete while
omitting sessions that fall beyond the global page, and loading another global
page can redistribute rows into several unrelated groups.
This RFC gives maintainers a concrete architecture to review before replacing
that behavior.
Why This Change Was Made
The proposal models the sidebar as an async tree: a lightweight root manifest
returns authoritative section summaries, while each expanded and visible
collection owns an independent cursor-backed child connection. A single
flattened virtual list controls rendered demand, and collapsed or distant groups
load no child rows.
The RFC also defines exact local counts, a canonical attention summary,
collection membership precedence, filter/cursor fencing, live invalidation,
bounded caching, failure states, migration steps, alternatives, and unresolved
thresholds.
The RFC remains
status: draft; its implementation issue stays blank untilmaintainer acceptance.
AI-assisted: yes. Jesse Merhi directed the product requirements and is credited
as an RFC author and commit co-author.
User Impact
This PR changes no shipped behavior. If accepted and implemented, operators
will get complete ordinary groups when they open them, accurate collapsed
counts and attention indicators, and no background loading for sidebar groups
they are not viewing.
Evidence
rfcs/0000-template.mdand includes all required frontmatterand top-level sections.
session-attention owners before defining the proposal.
Virtual, and the Relay cursor connection contract.
git diff --cached --checkpassed before commit.ownership rule, or unsupported new dependency.
authorize exporting the unpublished RFC before publication.