Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 17, 2026, 6:35 PM ET / 22:35 UTC (Revision 14). ClawSweeper reviewWhat this changesWindows package builds select and verify the stable OpenClaw release, preserve that selection across retries, and check package versions while retaining separate official-signing approval. Merge readiness✅ Ready for maintainer review This remains useful: current main still pins the upstream source. The versioning coordination request is addressed, the PR is now ready for review, and no blocking defect was found in the reduced scope. Priority: P2 Review scores
Verification
How this fits togetherThe packaging workflow turns upstream OpenClaw source into Windows MSIX packages for x64 and ARM64. Source selection feeds both builds, while the existing release policy separately controls official signing. flowchart TD
A[Npm stable or explicit source] --> B[Verify source identity]
C[Reviewed release policy] --> B
B --> D[Immutable run snapshot]
D --> E[Verified package and architecture builds]
E --> F[Official signing approval]
C --> F
F --> G[Signed Windows release]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Keep one stable-source resolver feeding both architectures, reuse the established MSIX identity contract, and retain explicit approval for official releases. Do we have a high-confidence way to reproduce the issue? Not applicable: this adds agreed source-selection behavior; current main's hardcoded selection is directly visible in the workflow. Is this the best way to solve the issue? Yes: the reduced implementation reuses existing packaging, identity, and signing checks while isolating stable selection and retry consistency. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning medium; reviewed against ad5df933da4f. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (13 earlier review cycles; latest 8 shown)
|
f692cb3 to
020ff94
Compare
af7a4e3 to
d11d1e0
Compare
|
@clawsweeper re-review The updated requirement is stable only. The extended-stable proposal is superseded: there is no cross-channel or automatic fallback, and a compatibility pin can select only a reviewed older known-good stable release. CI run 35032630892 successfully built OpenClaw 2026.9.4 for x64 and ARM64 and produced the bundle. The selected commit, The latest commit only removes obsolete setup inputs reported as ignored by that run; native |
|
🦞🧹 I asked ClawSweeper to review this item again. |
|
Versioning contract coordination: PR #36 is the foundational release-identity change and now owns the agreed mapping ( |
Resolve the public channel to a verified immutable source snapshot, carry its identity through packaging, and authorize official releases against the channel policy. Preserve snapshots on retries, derive release versions, reject duplicate or older publications, and update contributor documentation and coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Validate legacy version/commit-derived Control UI identities as well as modern build IDs, bind both to the resolved source, and deny workflow cache access with native cache-mode none. Preserve the manual entry point and document the current CodeQL modeling gap for review. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Let the selected upstream packer own its package-manager and changelog defaults. Retain its inventory and tarball validation without passing newer-only switches that older extended-stable releases reject. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Resolve stable through npm latest and reject extended-stable or prerelease sources, including explicit refs and legacy payload inputs. Allow only a reviewed exact stableVersion compatibility pin, with no automatic fallback. Preserve source/signing checks, map stable numeric corrections safely, and update regression coverage and documentation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The regular-stable setup action no longer accepts the old cache option names. Remove those ignored inputs while preserving workflow-wide native cache-mode none as the enforced security boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Favor PR36's existing identity, signing approval, payload/plugin and upgrade paths. Reduce PR42 to verified stable-source selection, immutable per-run source replay and selected-version verification. Remove the competing MSIX mapping, automatic signing authority and duplicate release guards; retain focused source and integration tests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
51c9ede to
c2fa7fa
Compare
Remove the unrelated cache-access restriction and its test. Trim documentation to source-selection behavior without prior-PR history or unrelated implementation notes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
What Problem This Solves
CI should choose the current OpenClaw stable release without a hardcoded source commit in the workflow.
Fixes #25.
User Impact
An empty
openclaw_refselects npmopenclaw@latest. The selected version and source commit are verified before building and kept fixed for retries.Extended stable and named prereleases are rejected. There is no automatic fallback. A reviewed
stableVersionpin can select an older known-good stable release, and unsigned/test runs can use an explicit stable-source ref.Official source selection must match the reviewed commit, version and tag in
release-policy.json.Why This Change Was Made
Evidence
Head:
cc7519668d11e132a490a1e23eef08e4b52320d2.Passed locally: 42 source-selection tests, package verification tests, workflow configuration checks, YAML validation and whitespace checks.
CI run 35281100228 is queued for this head.