Skip to content

fix(chat): multi-line composer messages sent with stray carriage returns #1682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shanselman merged 3 commits into from
Oct 15, 2026
+12 −1
Merged

fix(chat): multi-line composer messages sent with stray carriage returns #1682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
650c6e4
fix(chat): normalize composer line breaks sent to the gateway
larroy Oct 8, 2026
b3fcc8c
Merge origin/main into fix/chat-enter-send-line-endings
shanselman Oct 15, 2026
2750135
test(chat): use gated native keyboard proof
shanselman Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OpenClaw.Tray.WinUI/Chat/ChatComposerController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public async Task<bool> SendAsync()
var thread = inputs.CurrentThread;
var draft = _vm.Draft;
var attachments = _vm.PendingAttachments;
var message = draft.Trim();
var message = draft.Trim().Replace("\r\n", "\n").Replace('\r', '\n');
if ((message.Length == 0 && attachments.Count == 0)
|| _vm.SlashDisplay.IsLoading
|| inputs.ConnectionState != "connected")
Expand Down
11 changes: 11 additions & 0 deletions tests/OpenClaw.Tray.Tests/ChatComposerControllerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,17 @@ public async Task SendAsync_OrdinaryMessage_CallsProviderExactlyOnceAndClearsDra
Assert.Equal(string.Empty, vm.Draft);
}

[Fact]
public async Task SendAsync_TextBoxLineBreaks_AreSentAsLineFeeds()
{
var (vm, controller, port, _) = MakeController();
vm.SetDraft("line one\rline two\r\nline three");

Assert.True(await controller.SendAsync());

Assert.Equal("line one\nline two\nline three", port.LastSendMessageCall!.Value.Message);
}

[Fact]
public async Task SendAsync_ActiveTurn_AcceptedFollowUpClearsComposerAndAllowsAnotherDraft()
{
Expand Down
Loading