Repository navigation
fix(onboarding): clarify native gateway update guidance - #1654
natalie-aguinaldo wants to merge 4 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 7, 2026, 12:45 PM ET / 16:45 UTC (Revision 6). ClawSweeper reviewWhat this changesThe PR clarifies native Gateway update guidance in six languages, adds accessible text emphasis, and expands onboarding documentation and rendering tests. Merge readiness✅ Ready for maintainer review This PR remains useful: main and the latest release retain the older build-number guidance. The prior copy concerns and merge conflict are resolved, and no introduced correctness defect was found. Priority: P3 Review scores
Verification
How this fits togetherThe onboarding Welcome page checks whether Windows supports a local native Gateway. That result controls gateway choices and the update guidance shown to users. flowchart TD
A[Welcome page] --> B[Windows capability probe]
B --> C[Support result]
C --> D[Gateway choices]
C --> E[Localized guidance]
E --> F[Accessible text rendering]
F --> G[Windows Update action]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep capability-based admission and present clear, localized update guidance with enrollment consequences and accessible rendering. Do we have a high-confidence way to reproduce the issue? Not applicable to this guidance improvement. Current main's older copy is directly inspectable, and the supplied native WinUI evidence demonstrates the revised rendering. Is this the best way to solve the issue? Yes. The focused presentation helper preserves complete localized text and accessibility while leaving capability checks and user-controlled Windows settings intact. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 5e3fb40bcc89. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
Adversarial dual-model reviewVerdict: approve with nits. No blocking correctness findings. Claude Opus 5.5 and GPT-6 Astra independently reviewed all 17 changed files using the same brief, then their findings were reconciled. Reviewed head: Both reviewers found the rendering/fallback logic, complete localized text preservation, automation-name resets, and unchanged capability admission sound at source level. Opus raised the non-blocking concerns below; GPT reported no actionable findings. Both models agree: HIGH consensus
Only one model flagged: LOW consensusConsensus describes reviewer agreement, not severity. Fix confidence estimates confidence in the proposed remediation.
Verification
|
Clarify Advanced options and the clean-reinstall trade-off in every locale, restore rollout and recheck guidance, and exercise production rich-text and accessibility resets on real WinUI controls. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Implemented the review follow-ups in 3dcf88a1, pushed to this PR's existing branch.
Validation: full Current-change UI evidence: the production renderer and compiled product resources ran on real native ARM64 WinUI controls. The capture below is a |
|
Global triage: HOLD_FOR_AUTHOR. Take confidence 10%; recommendation confidence 99%; effort medium; risk high. Reviewed exact head Author: update from current main, resolve conflicts or branch-policy blockers, then rerun exact-head validation and request review. This is a triage classification, not a merge action. No branch changes were made. |

What Problem This Solves
Fixes unclear Windows update instructions when native Gateway support is unavailable during onboarding.
User Impact
Users receive three readable, selectively emphasized paragraphs in all six supported languages, including selecting 26H1 under Advanced options, the clean reinstall required to return to 25H2/26H2, device-dependent feature availability, and reopening setup to recheck after updating. Companion does not enroll the device or change Windows update settings automatically.
Why This Change Was Made
Replaces pinned build-number guidance with rollout-aware Windows 11, version 26H1 instructions while retaining the live capability probe as the admission authority. Localized emphasis preserves the complete screen-reader text and safely falls back to plain rendering if translation tokens drift. Architecture and onboarding documentation match the same contract.
Follow-up 3dcf88a1 addresses the adversarial review: enrollment trade-offs, restored recheck guidance, localized copy checks, real WinUI rendering/accessibility-reset coverage, and production rendering in the gallery.
Evidence
Seven real WinUI tests verify complete paragraph text, all six emphasized spans, automation peer names, idempotent rendering, and rich/plain transitions. Six localized copy cases guard the new enrollment, reinstall, rollout, and reopen instructions. The follow-up rubber-duck review found no blocking issue; runtime tests resolved its speculative Text/Inlines and automation-sentinel concerns.
The author's earlier full-window screenshot applies to 3c1e7ff before the follow-up, not the current wording. Current-change renderer evidence is below.
Change Type
Scope
winnodeRequired proof pools
windows-winui-interactive: native Gateway unavailable-state copy and accessibility. Current-change real WinUI control proof collected; full Welcome-window/Narrator proof was not rerun.Validation
Final source state committed as
3dcf88a1dd8722f969a13bed63776ae21fc20f98, validated locally on native Windows ARM64:.\build.ps1: passed, all projects.dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore --logger 'console;verbosity=minimal': 4,260 passed, 34 skipped, 0 failed.dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore --logger 'console;verbosity=minimal': 4,002 passed, 0 skipped, 0 failed..\scripts\run-proof-tests.ps1 -Project 'tests\OpenClaw.Tray.UITests\OpenClaw.Tray.UITests.csproj' -Filter 'FullyQualifiedName~NativeGatewayEligibilityTextTests' -ResultName 'native-gateway-guidance' -RuntimeIdentifier win-arm64: 7 passed, 0 skipped, 0 failed, including a visible-testhost rerun.git diff --cached --check: passed before commit.OPENCLAW_REPO_ROOTpointed at this worktree;OPENCLAW_TRAY_DATA_DIRused isolated test directories. The capture run also setOPENCLAW_UI_PROOF_DIR,SLOW_UI_TESTS=1, andSLOW_UI_STEP_MS=1. Initial missing Shared test assets were restored. An attempted broad friend-assembly grant caused a duplicate linked-type compilation error and was removed; tests now bind only the production methods under test. All required commands were rerun successfully after corrections.The author's earlier Dev MSIX packaging result applies to
3c1e7ff0; Dev MSIX packaging was not rerun for this follow-up.Real Behavior Proof
3dcf88a1dd8722f969a13bed63776ae21fc20f98.run-proof-tests.ps1command above; productionApply/ApplyPlaininvoked on realTextBlockcontrols.Yes/No/N/A): Yes. Downloaded the attached image after posting and verified its SHA-256 matches the inspected local image.Copied runtime output:
The following is a
RenderTargetBitmapof the production-rendered, test-hosted TextBlock. Transparent pixels were composited onto white for legibility; it is not a full app-window screenshot.Security Impact
Yes/No): NoYes/No): NoYes/No): NoYes/No): NoYes/No): NoYes, explain the risk and mitigation: N/ACompatibility and Migration
Yes/No): YesYes/No): NoYes/No): NoReview Conversations
The follow-up comment records the three addressed review concerns and current validation. No formal approval or merge was performed.