Skip to content

fix(release): trust downloaded Dev MSIX certificates machine-wide #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomneyDa merged 1 commit into from
Oct 2, 2026
Merged

fix(release): trust downloaded Dev MSIX certificates machine-wide #1607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1378,7 +1378,10 @@ jobs:
- name: Trust signed Dev MSIX certificates for validation
shell: pwsh
run: |
$storePath = 'Cert:\CurrentUser\TrustedPeople'
# setup-dev-msix-cert.ps1 validates these self-signed packages through
# LocalMachine trust. Use the same store after artifact download so
# Get-AuthenticodeSignature evaluates the package as Valid.
$storePath = 'Cert:\LocalMachine\TrustedPeople'
$thumbprintsPath = "$env:RUNNER_TEMP\openclaw-dev-msix-imported-certs.txt"
[IO.File]::WriteAllText($thumbprintsPath, '')
foreach ($architecture in @('x64', 'arm64')) {
Expand Down Expand Up @@ -1424,7 +1427,7 @@ jobs:
$thumbprintsPath = "$env:RUNNER_TEMP\openclaw-dev-msix-imported-certs.txt"
if (Test-Path -LiteralPath $thumbprintsPath) {
foreach ($thumbprint in @(Get-Content -LiteralPath $thumbprintsPath)) {
Get-ChildItem -LiteralPath 'Cert:\CurrentUser\TrustedPeople' |
Get-ChildItem -LiteralPath 'Cert:\LocalMachine\TrustedPeople' |
Where-Object Thumbprint -EQ $thumbprint |
Remove-Item -Force
}
Expand Down
2 changes: 2 additions & 0 deletions tests/OpenClaw.Tray.Tests/ReleaseSigningWorkflowTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,8 @@ public void ReleaseWorkflow_PublishesSignedDevMsixForEveryTag()
Assert.Contains("name: Download x64 signed Dev MSIX release artifact", workflow);
Assert.Contains("name: Download ARM64 signed Dev MSIX release artifact", workflow);
Assert.Contains("name: Trust signed Dev MSIX certificates for validation", workflow);
Assert.Contains(@"$storePath = 'Cert:\LocalMachine\TrustedPeople'", workflow);
Assert.DoesNotContain(@"Cert:\CurrentUser\TrustedPeople", workflow);
Assert.Contains("name: Stage signed Dev MSIX release assets", workflow);
Assert.Contains("name: Remove trusted Dev MSIX certificates", workflow);
Assert.Contains("Get-AuthenticodeSignature -LiteralPath $packagePath", File.ReadAllText(
Expand Down
Loading