Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review blockedAutomated review did not run, so no review verdict was produced. Reason: The input-safety check rejected material in this revision. No detected value, path, or scanner output is reproduced here. Automatic review is on hold, including after source changes. Request a fresh re-review after resolving the failure; maintainers can also release the hold through an intentional scanner-policy update. Next step: If this is a genuine credential, remove and rotate it. If it is an intentional test fixture, a maintainer must review and qualify it. |
Add native gateway and AI onboarding, verified Chat/Channels/Skills completion, isolated startup behavior, and ownership-safe persistence and recovery. Remove superseded onboarding paths and include focused regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Handle the CLR-projected file-not-found exception from Task Scheduler without suppressing other failures. Cover the real read-only missing-task query. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve vendor artwork bytes, isolate every UI test data root, and separate native proof from framework coverage. Drain artwork requests before transport disposal, restore provider focus without viewport drift, and await actual model flyout transitions. Bind framework card actions to exact XAML declarations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the native route's startup behavior, disambiguate localization keys, and retain cleanup and contract coverage across the merged flows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
bkudiess
force-pushed
the
bkudiess-windows-onboarding-plan
branch
from
September 28, 2026 21:09
382a9bd to
e93f756
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
Windows onboarding needs a coherent native path from Gateway connection and PC access choices to a verified AI and a useful first task.
User Impact
Users can configure a Gateway, choose PC access, connect an AI provider, and finish in native Chat, Channels, or Skills. Talk to my agent is Recommended. Provider authorization uses one focused dialog without duplicated device-code text.
Why This Change Was Made
This combines native onboarding, Local AI/connection recovery, verified destination handoff, and supporting artwork/accessibility. Superseded permission-preview and browser-completion paths are removed. Credential identity, concurrent persistence, cancellation, startup preferences, and restart recovery are guarded and regression-tested.
Draft: final hosted CI and current-head live proof are still in progress. Main was merged and conflicts resolved while retaining its Store/Inno migration safeguards. No remaining integration defect was found by either independent reviewer.
Evidence
2026.9.6, paired the test profile, and verifiedproof/proof-okthrough the real Gateway with a synthetic local provider (670 ms). No real provider credentials were used.Change Type
Scope
winnodeRequired proof pools
windows-winui-interactive: native onboarding, authorization, accessibility, destinations, and startup/restart recovery.windows-wsl-gateway-e2e: WSL setup, pairing, persistence/recovery, and verified completion.windows-wsl-mxc: applicable setup/connect and containment E2E proof. Not yet passed for this head.Validation
Current head:
ee5afb5e0eb8073e59fcc68fc5e6be284be7665c, resolved tree6a9628330d094fb0258eb8a4d4172b708715d90f. This exact source tree passed validation before the merge commit was created; source content did not change during publication..\build.ps1dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restoredotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restoredotnet test .\tests\OpenClaw.Connection.Tests\OpenClaw.Connection.Tests.csproj --no-restoredotnet test .\tests\OpenClaw.SetupEngine.Tests\OpenClaw.SetupEngine.Tests.csproj --no-restore.\scripts\validate-mxc-e2e.ps1 -NoBuild -ResultsDirectory <isolated results>All tests used isolated roots. Earlier disposal/timing flakes and stale metadata failures were retained; final full local closeout passed after recovery. Hosted CI is pending and is not represented by local counts.
Real Behavior Proof
e4d0cd1; the completed missing-task fix probe maps toa62ec5d1. These are explicitly prior-head evidence, not full proof ofee5afb5e.SetupEngine.Program.Mainprovisioning with a pinned Gateway, followed by productGatewayAiSetupClientdiscovery/verification; finite guest Task Scheduler enable/preserve/disable probe; framework UI tests and separately labeled full-frame/UIAutomation captures.Absent -> ExpectedEnabled -> preserved -> Absent, and the owned task/Run value were removed.N/A(no final-head media uploaded yet).0x80072EE6); separate full-frame/UIAutomation evidence is not counted as an OCR-harness pass. Canonical MXC setup currently encounteredStateDatabaseCoordinatorContentionErrorwhile recording Gateway restart intent; the ownership guard was not bypassed.Security Impact
Nonew node capability permission; existing opt-in choices are exposed.YesYesYes, setup/validation orchestration; no new node command.Yes, reviewed settings patches and profile-local identity/receipt coordination.Compatibility and Migration
ai-v2browser handles and incomplete development receipts fail visibly rather than being trusted.Nomanual onboarding migration. Main's Store/Inno migration safeguards are preserved. Existing numeric native destination values are retained.Review Conversations
This PR will remain draft until remaining validation/proof gates are completed or a maintainer explicitly accepts the documented limitations.