Bump Microsoft.WindowsAppSDK from 2.4.0 to 2.5.1

[karkarl]

Supersedes #1455 because its Dependabot-owned head was 21 commits behind main and does not permit maintainer edits. This branch preserves the original one-line dependency scope and rebases it cleanly onto 5a59535216eea603192f2df13d4eddf1e1a20267.

Updates MicrosoftWindowsAppSDKVersion from 2.4.0 to 2.5.1 for the tray, setup UI, FunctionalUI, and WinUI test consumers.

Required proof pools

none: this is a dependency-only change with no user-facing workflow or UI contract change. Runtime-oriented WinUI tests and both architecture builds are recorded below.

Validation

• OPENCLAW_REPO_ROOT=<worktree> .\build.ps1 - passed
• dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore - 4,107 passed, 32 skipped
• dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore - 3,115 passed
• dotnet test .\tests\OpenClaw.Tray.UITests\OpenClaw.Tray.UITests.csproj --no-restore -r win-x64 - 231 passed, 5 skipped
• dotnet test .\tests\OpenClawTray.FunctionalUI.Tests\OpenClawTray.FunctionalUI.Tests.csproj --no-restore - 19 passed
• dotnet build .\src\OpenClaw.Tray.WinUI\OpenClaw.Tray.WinUI.csproj --no-restore -r win-arm64 --configuration Debug - passed
• Windows App Runtime 2.5.1 x64 installer URL used by CI - HTTP 200

Real behavior proof

• Current-head x64 WinUI/A2UI tests started the real Windows App SDK runtime and passed 231 tests.
• Current-head FunctionalUI tests passed all 19 tests.
• Current-head ARM64 WinUI, SetupEngine.UI, and FunctionalUI dependency graph compiled successfully on the x64 host. Native ARM64 launch was not performed.

Review

• Adversarial whole-diff review: no actionable findings.
• Independent GPT-5.6 Sol code review: no findings.
• Claude rubber-duck review: no in-scope blocker; its package URL, lock-file, notification API, and consumer-coverage observations were independently checked.
• Project autoreview command was invoked in branch mode against origin/main with Codex gpt-5.6-sol / high, but the Codex endpoint returned HTTP 401. This is an explicit review-proof blocker, not a clean autoreview result.

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

[clawsweeper]

Codex review: blocked before merge. Reviewed September 25, 2026, 7:44 PM ET / 23:44 UTC.

ClawSweeper review

What this changes

Updates the shared Windows App SDK version to 2.5.1 for the tray application, setup UI, FunctionalUI library, and WinUI tests.

Merge readiness

⛔ Blocked before merge - 2 items remain

Current main and the latest release still use Windows App SDK 2.4.0, so this replacement PR remains useful. The version change is narrow, but the native startup and navigation proof requested for the same upgrade remains incomplete.

Priority: P2
Reviewed head: 6fd358aefda7c440ac80b16909bef2868336627e

Review scores

Measure	Result	What it means
Overall readiness	🦐 gold shrimp (3/6)	The focused package update has substantial build and x64 runtime validation, while requested native application and ARM64 observations remain open.
Proof confidence	🦐 gold shrimp (3/6)	Not applicable: The collaborator proof gate does not apply. The PR reports current-head x64 tests that bootstrap the real Windows App SDK runtime, with 231 WinUI and 19 FunctionalUI tests passing; it does not record isolated tray navigation or native ARM64 launch. No stored-data contract changes.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Not applicable	Not applicable: The collaborator proof gate does not apply. The PR reports current-head x64 tests that bootstrap the real Windows App SDK runtime, with 231 WinUI and 19 FunctionalUI tests passing; it does not record isolated tray navigation or native ARM64 launch. No stored-data contract changes.
Evidence reviewed	10 items	Introduced change: The pinned PR diff changes only the shared Windows App SDK version from 2.4.0 to 2.5.1. Still needed on main: The pinned current-main version remains 2.4.0. Latest release baseline: The supplied latest release, v2026.9.4, also uses 2.4.0.
Findings	None	None.
Security	None	None.

How this fits together

A shared build property selects the Windows App SDK package used by the native Windows application and its UI projects. The package affects shipped x64 and ARM64 apps, while CI installs a matching runtime for UI tests.

flowchart LR
  A[Shared SDK version] --> B[Package resolution]
  B --> C[Tray and setup UI]
  B --> D[WinUI test host]
  C --> E[x64 and ARM64 packages]
  E --> F[App launch and navigation]
  D --> G[Runtime test results]

Loading

Before merge

• Resolve merge risk (P1) - Existing x64 or ARM64 installations could fail to start or navigate correctly after the bundled runtime changes. The reported x64 test-host run and ARM64 compilation do not satisfy the previously requested isolated-app launch/navigation and native ARM64 startup checks.
• Complete next step (P2) - Declare the windows-winui-interactive and windows-11-arm64 proof pools, then record current-head isolated tray launch/navigation and native ARM64 startup results before merge.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Dependency reach	1 shared version changed; 4 direct package consumers	The small diff changes the native dependency for the tray, two UI libraries, and UI tests.

Root-cause cluster

Relationship: canonical
Canonical: #1522
Summary: This PR is the active replacement for the closed, unmerged Dependabot submission of the same SDK update.

Members:

• superseded: Bump Microsoft.WindowsAppSDK from 2.4.0 to 2.5.1 #1455 - Its author closed it and identified this rebased branch as the replacement.

Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything.

Merge-risk options

Maintainer options:

1. Complete native runtime validation (recommended)
   Use the declared WinUI interactive and native ARM64 proof pools to record current-head app launch, navigation, and ARM64 startup before merge.

Technical review

Best possible solution:

Keep the centralized version update and verify current-head isolated tray navigation plus native ARM64 startup before shipping the new runtime.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR updates a dependency and reports no specific bug. Its validation results are recorded in the PR body; this read-only review did not execute them.

Is this the best way to solve the issue?

Yes: changing the existing shared version property keeps all four direct package consumers aligned. Native compatibility still needs the previously requested proof.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against 5a59535216ee.

Labels

Label changes:

• add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.

Label justifications:

• P2: This is a useful native dependency update with no demonstrated urgent user regression.
• merge-risk: 🚨 compatibility: The self-contained UI runtime changes across supported architectures while requested native startup and navigation proof remains outstanding.
• rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Not applicable: The collaborator proof gate does not apply. The PR reports current-head x64 tests that bootstrap the real Windows App SDK runtime, with 231 WinUI and 19 FunctionalUI tests passing; it does not record isolated tray navigation or native ARM64 launch. No stored-data contract changes.

Evidence

What I checked:

• Introduced change: The pinned PR diff changes only the shared Windows App SDK version from 2.4.0 to 2.5.1. (Directory.Build.props:4, 6fd358aefda7)
• Still needed on main: The pinned current-main version remains 2.4.0. (Directory.Build.props:4, 5a59535216ee)
• Latest release baseline: The supplied latest release, v2026.9.4, also uses 2.4.0. (Directory.Build.props:4, 3c43751b2bac)
• Native package reach: The tray directly consumes the shared version and builds self-contained unpackaged and MSIX distributions for x64 and ARM64; three other project files also reference the property. (src/OpenClaw.Tray.WinUI/OpenClaw.Tray.WinUI.csproj:124, 5a59535216ee)
• Runtime test boundary: The WinUI test fixture bootstraps a system-installed Windows App Runtime and creates a real WinUI Application and hidden Window. Its passing tests are meaningful x64 runtime coverage, but do not launch the shipped tray app. (tests/OpenClaw.Tray.UITests/UIThreadFixture.cs:201, 5a59535216ee)
• Recorded current-head validation: The PR body reports a full build, 4,107 Shared tests, 3,115 Tray tests, 231 x64 WinUI tests, 19 FunctionalUI tests, and an ARM64 compile. It expressly says native ARM64 launch was not performed. (6fd358aefda7)

Likely related people:

• karkarl: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
• natalie-aguinaldo: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
• shanselman: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)
• steipete: Suggested for follow-up; no historical authorship or introduction is verified. (role: unverified routing candidate; confidence: low)

Rank-up moves

Optional improvements that raise the rating; they are not merge blockers.

• Record current-head isolated WinUI launch/navigation and native ARM64 startup results under the previously requested proof pools.

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.