feat(msix): publish multi-architecture Store bundle - #1452
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 19, 2026, 10:54 PM ET / September 20, 2026, 02:54 UTC (Revision 2). ClawSweeper reviewWhat this changesAdds a single unsigned x64/ARM64 Store submission bundle, validates its embedded packages, and integrates it into CI and alpha release publication. Merge readiness⛔ Blocked before merge - 2 items remain The previous version-boundary finding is resolved, and no additional actionable defect was found. Current main lacks bundle publication, so this member-authored PR remains useful. Priority: P2 Review scores
Verification
How this fits togetherThe release pipeline builds architecture-specific Windows packages using one allocated version. Bundle construction combines those packages, and alpha release staging checks their identity and hashes before publishing submission assets. flowchart LR
A[Shared package version] --> B[x64 and ARM64 packages]
B --> C[Windows bundle builder]
C --> D[CI release gate]
C --> E[Identity and hash checks]
B --> E
E --> F[Alpha submission assets]
D --> F
Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Preserve the member-requested release gate, shared version allocation, and byte-preserving bundle validation while retaining standalone submission assets. Do we have a high-confidence way to reproduce the issue? Not applicable to the feature itself. Source inspection confirms the previous version-boundary defect is removed and both requested boundary cases are covered. Is this the best way to solve the issue? Yes. Composing existing validated packages with MakeAppx avoids duplicating package production and preserves the existing allocation and provenance contracts. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 8ed7c56dfd02. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
|
@clawsweeper re-review Addressed the actionable finding in 49d3a72:
Focused bundle, alpha staging, CI Gate, and workflow contract tests pass. The prior reviewed head also completed the real Windows MakeAppx bundle job successfully: https://github.com/openclaw/openclaw-windows-node/actions/runs/35482955166/job/106005091185. Exact-head CI is running now. |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Summary
Required proof pools
Validation
Passed locally:
Local Windows-only closeout blockers on macOS:
Real behavior proof
Not verified locally: MakeAppx.exe and the two real architecture packages require Windows. This PR adds a Windows CI bundle job that runs MakeAppx.exe against the exact x64 and ARM64 artifacts, uploads the resulting bundle, and makes both CI Gate and tag publication fail closed if that job does not succeed.