Repository navigation
Conversation
Reapply the rename-only change from 19da046 on current upstream main. Update both Store and Dev filenames, metadata, installation instructions, alpha staging, CI upload paths, documentation, and tests without changing package versions, identities, UI, signing, or EXE names. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: cb0e5a80-d2cf-41b0-9fb0-21eb32623526
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
clawsweeper
Bot
added
P3
|
Codex review: needs maintainer review before merge. Reviewed September 18, 2026, 2:12 PM ET / 18:12 UTC (Revision 3). ClawSweeper reviewWhat this changesRenames Windows MSIX downloads to OpenClaw and updates packaging, CI uploads, release staging, documentation, and filename tests. Merge readiness✅ Ready for maintainer review The change remains useful because main still uses the previous filenames. No actionable defects remain, the real artifact proof is sufficient, and the previous draft blocker is resolved. Priority: P3 Review scores
Verification
How this fits togetherThe Windows packaging pipeline produces unsigned Store packages and signed development packages for x64 and ARM64. Export scripts attach provenance and installation instructions before CI uploads or alpha-release staging. flowchart TD
A[Windows package builds] --> B{Package kind}
B --> C[Unsigned Store export]
B --> D[Signed development export]
C --> E[Named packages and metadata]
D --> E
E --> F[CI downloads]
F --> G[Store alpha release staging]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep the existing packaging pipeline and use consistent OpenClaw filenames throughout export, download instructions, and release staging. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a filename cleanup, and main's previous naming is directly visible in source. Is this the best way to solve the issue? Yes. Updating the existing producers and consumers together avoids a parallel packaging path, and real output proof covers the resulting names. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 0246e33f6e8f. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
History |
|
@clawsweeper re-review Added real current-head package-output evidence to the PR body for reviewed head CI run 35369292102 is green, including both native MSIX jobs and CI Gate. I downloaded and inspected its four actual artifacts:
All four renamed filenames match Add-AppxPackage -Path .\OpenClaw-Dev-x64.msix
Add-AppxPackage -Path .\OpenClaw-Dev-arm64.msixI also ran the current production Both packages and both metadata files were preserved byte-for-byte. Full hashes and the staging invocation are in the updated body. The alpha-format argument was a local stager input only, not a created tag or published release. Provenance: all four packages record clean CI merge commit No installation, certificate-trust changes, Partner Center submission, or release publication was performed. |
|
🦞🧹 I asked ClawSweeper to review this item again. |
clawsweeper
Bot
added
proof: sufficient
karkarl
left a comment
karkarl
left a comment
There was a problem hiding this comment.
Approved. Independent adversarial reviews by Claude Opus 4.8 and GPT-5.3 Codex found no actionable issues or disagreements at e87cd49.
The MSIX filename rename is consistent across Store/Dev package producers, CI uploads, metadata, release staging, documentation, and tests. Package identities, versions, and EXE installer filenames remain unchanged.
Validation passed:
- scripts/test-ci-workflow-contract.ps1
- scripts/test-msix-alpha-release.ps1
- scripts/test-msix-ci-artifacts.ps1
The alpha test passed after selecting the existing full Git installation on PATH. Review limitations: no full build, Shared/Tray test suites, or real MSIX packaging/install run.
2 participants
Summary
Rename only the MSIX download files from
OpenClawCompaniontoOpenClaw.OpenClaw-x64.msix,OpenClaw-arm64.msix.OpenClaw-Dev-x64.msix,OpenClaw-Dev-arm64.msix.This is the rename-only change from commit
19da0469, applied independently to upstreammain. It contains no temporary branch exceptions or version overrides. Package identities, display names, capabilities, signing, MSIX version calculation, EXE installer names, and artifact ZIP labels remain unchanged. Existing downloads are not renamed.The permanent encoded-versioning work belongs in a separate PR.
Required proof pools
none: artifact filename and matching reference changes only. No package payload, native dependency, install/upgrade logic, UI, or runtime behavior changes. Hosted CI covers x64 and ARM64 package production. No custom-host runtime claims are made.Validation
Current-head hosted CI passed: Build and Test run 35369292102, including CI Gate and both native MSIX packaging/export jobs:
Completed on the final rename source tree against
mainat0246e33f:.\build.ps1: all projects passed.dotnet test .\tests\OpenClaw.Shared.Tests\OpenClaw.Shared.Tests.csproj --no-restore: 3,983 passed, 33 skipped, 0 failed.dotnet test .\tests\OpenClaw.Tray.Tests\OpenClaw.Tray.Tests.csproj --no-restore: 2,979 passed, 0 failed..\scripts\test-msix-ci-artifacts.ps1: passed..\scripts\test-ci-workflow-contract.ps1: passed..\scripts\test-msix-alpha-release.ps1: passed..\scripts\validate-docs.ps1: passed.git diff --cached --check: passed.Tests used isolated tray settings and an environment-only official NuGet source configuration.
Real behavior proof
Current-head real Windows packages, not fixtures
Downloaded and inspected all four real artifacts from run
35369292102. The artifact API identifies reviewed PR heade87cd49cdf27cbd0565138218bbf2c741a463adf. All four metadata files record clean source commitd279299f5cba0ddaaeee7a28c2a5992e39ee650c, the CI PR-merge checkout. Its tree SHA47d3a5c249dbbd3698345a360674c1d67fa3d9e7exactly matches the reviewed head's tree.OpenClaw-x64.msix2026.9.5.0OpenClaw-arm64.msix2026.9.5.0OpenClaw-Dev-x64.msix2026.9.5.3266OpenClaw-Dev-arm64.msix2026.9.5.3266These are this rename-only PR's normal GitVersion versions, not the earlier experimental
400version-override artifacts.Verified directly against the downloaded files:
msix-metadata.json.msix-metadata.json, public-onlyOpenClaw-Dev.cer, andINSTALL.txt.archiveequals the actual renamed filename; package SHA-256, embedded manifest identity/publisher/architecture/version, and clean source provenance all match.OpenClawFoundation.OpenClawand have noAppxSignature.p7x. Dev packages retainOpenClawFoundation.OpenClaw.Dev.INSTALL.txtfiles contain the correct commands:Verified SHA-256 values of the MSIX files inside the downloads
Alpha stager exercised with the real Store packages
Ran the unchanged, current-head production stager locally against the downloaded x64 and ARM64 Store artifacts:
Here,
2026.9.5-alpha.0is only an alpha-format argument for exercising the stager against the already-built2026.9.5.0packages. No such tag or release was created, and neither package version nor metadata was rewritten.Actual output:
This demonstrates actual Store build output, signed Dev export output, installation-command naming, and byte-preserving Store asset staging for both architectures. It does not claim a tagged release was published.
Not verified / blocked
python .agents\skills\autoreview\scripts\autoreview --mode localremains unavailable because the Codex executable is missing. No local helper success is claimed.