docs: make PR descriptions plain-language first - #43
Conversation
Co-authored-by: hannesrudolph <49103247+hannesrudolph@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 12, 2026, 3:49 PM ET / 19:49 UTC. ClawSweeper reviewWhat this changesUpdates the PR template to put plain-language problems and user outcomes first while keeping risks, required actions, and evidence summaries visible. Merge readiness⛔ Blocked before merge - 1 item remains Keep open: this is a focused, useful template improvement that is not yet on Hermit’s main branch. No blocking correctness or security issues were found. Priority: P3 Review scores
Verification
How this fits togetherHermit’s GitHub PR template guides contributors when writing descriptions for review. Its prompts shape how reviewers see the problem, impact, rationale, and validation. flowchart LR
A[Contributor opens PR] --> B[GitHub description template]
B --> C[Problem and user impact]
B --> D[Rationale and evidence]
C --> E[Maintainer review]
D --> E
Before merge
Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Use one concise template that foregrounds outcomes and preserves visible risk, action, and validation summaries. Do we have a high-confidence way to reproduce the issue? Not applicable: this changes contributor writing guidance rather than repairing a runtime failure. Is this the best way to solve the issue? Yes: editing the existing template is the narrowest approach, and its required sections remain compatible with current review guidance. AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning medium; reviewed against 9b8cede7c0ad. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Related: openclaw/openclaw#146253
What Problem This Solves
PR authors need clearer prompts to explain the problem and outcome before technical detail.
User Impact
User impact: Contributors are prompted to write short, plain-language descriptions while keeping risks, required actions, and evidence visible. No runtime changes or migrations.
Why This Change Was Made
Carry the approved core template into hermit without changing section names or review requirements.
Evidence
Compared the current template with the rollout baseline, reviewed repository guidance, and checked all four headings, the blank-template marker, and whitespace. All passed. No runtime tests run for this wording-only change.