Skip to content

ci: fail incomplete docs translation runs#38

Merged
vincentkoc merged 2 commits into
openclaw:mainfrom
hxy91819:codex/i18n-finalizer-fail-incomplete
Jun 9, 2026
Merged

ci: fail incomplete docs translation runs#38
vincentkoc merged 2 commits into
openclaw:mainfrom
hxy91819:codex/i18n-finalizer-fail-incomplete

Conversation

@hxy91819

@hxy91819 hxy91819 commented Jun 9, 2026

Copy link
Copy Markdown
Member

Summary

  • keep applying and committing successful locale artifacts in Translate All
  • mark the finalizer output as incomplete when locale artifacts are missing or carry failed_reason
  • fail the Translate All run after successful artifacts are processed when the translation set is incomplete

Related CI / Incident

Verification

  • local finalizer fixture: complete artifact set reports incomplete_count=0
  • local finalizer fixture: one failed locale plus one missing locale reports incomplete_count=2 and writes the failed/missing locale list
  • python -c YAML parse for .github/workflows/translate-all.yml
  • actionlint .github/workflows/translate-all.yml
  • git diff --check
  • autoreview clean: no accepted/actionable findings

Notes

This preserves the existing partial-success design from ci: tolerate failed locale translation artifacts: successful locale artifacts can still be applied and deployed. The run is only marked failed at the end so maintainers do not mistake an incomplete or zero-change translation pass for a fully successful refresh.

@hxy91819 hxy91819 requested a review from a team as a code owner June 9, 2026 03:25
@hxy91819

hxy91819 commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

This workspace is deactivated. Select an active workspace and try again.
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@vincentkoc vincentkoc force-pushed the codex/i18n-finalizer-fail-incomplete branch from cc35a20 to 45485ea Compare June 9, 2026 04:47
@vincentkoc vincentkoc force-pushed the codex/i18n-finalizer-fail-incomplete branch from 45485ea to 58577d9 Compare June 9, 2026 04:48

@vincentkoc vincentkoc left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings.

I pushed one maintainer cleanup commit before approval: grouped the stale-branch GITHUB_OUTPUT writes so the workflow passes actionlint cleanly.

Proof run on the final head 58577d911c882854558ecf6f45b9833d3d446c20:

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/translate-all.yml"); puts "yaml ok"'
  • go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/translate-all.yml
  • git diff --check origin/main...HEAD
  • local finalizer fixture for failed + missing locale artifacts producing nonzero incomplete_count
  • structured autoreview: autoreview --mode branch --base origin/main --prompt "Review openclaw/docs PR #38..." -> clean, no accepted/actionable findings
  • CodeQL run https://github.com/openclaw/docs/actions/runs/27184510558 -> analyze (actions) and analyze (javascript-typescript) succeeded

Best-fix verdict: best small workflow fix. It keeps the existing partial-success design, applies/deploys successful locale artifacts first, skips stale source artifacts, and only fails the run after the finalizer can report missing or failed locales.

@vincentkoc vincentkoc merged commit 5346add into openclaw:main Jun 9, 2026
3 checks passed
@hxy91819

hxy91819 commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

Post-merge validation for 5346adda1d615403322c9197c1875299655f6f1b completed.

Result: passed.

  • The merge commit triggered CodeQL on push: https://github.com/openclaw/docs/actions/runs/27184622598
  • Both CodeQL jobs passed: analyze (actions) and analyze (javascript-typescript).
  • No Translate All, R2 Pages, Pages, or docs deploy workflow was expected for this merge commit because the PR only changed .github/workflows/translate-all.yml, and those workflows do not include that path in their push triggers.

This matches the repository CI configuration for the post-merge path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants