ci: fail incomplete docs translation runs#38
Conversation
|
@codex review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
cc35a20 to
45485ea
Compare
45485ea to
58577d9
Compare
vincentkoc
left a comment
There was a problem hiding this comment.
No blocking findings.
I pushed one maintainer cleanup commit before approval: grouped the stale-branch GITHUB_OUTPUT writes so the workflow passes actionlint cleanly.
Proof run on the final head 58577d911c882854558ecf6f45b9833d3d446c20:
ruby -e 'require "yaml"; YAML.load_file(".github/workflows/translate-all.yml"); puts "yaml ok"'go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/translate-all.ymlgit diff --check origin/main...HEAD- local finalizer fixture for failed + missing locale artifacts producing nonzero
incomplete_count - structured autoreview:
autoreview --mode branch --base origin/main --prompt "Review openclaw/docs PR #38..."-> clean, no accepted/actionable findings - CodeQL run https://github.com/openclaw/docs/actions/runs/27184510558 ->
analyze (actions)andanalyze (javascript-typescript)succeeded
Best-fix verdict: best small workflow fix. It keeps the existing partial-success design, applies/deploys successful locale artifacts first, skips stale source artifacts, and only fails the run after the finalizer can report missing or failed locales.
|
Post-merge validation for Result: passed.
This matches the repository CI configuration for the post-merge path. |
Summary
failed_reasonRelated CI / Incident
failed_reason: translation failedandchanged_count: 0.changed paths: 0, so stale localized files such asdocs/zh-CN/channels/line.mdwere not rewritten while the workflow still looked green.Verification
incomplete_count=0incomplete_count=2and writes the failed/missing locale listpython -cYAML parse for.github/workflows/translate-all.ymlactionlint .github/workflows/translate-all.ymlgit diff --checkNotes
This preserves the existing partial-success design from
ci: tolerate failed locale translation artifacts: successful locale artifacts can still be applied and deployed. The run is only marked failed at the end so maintainers do not mistake an incomplete or zero-change translation pass for a fully successful refresh.