refactor: remove unwired Station primitive - #1205
Conversation
|
Codex review: needs maintainer review before merge. Reviewed July 29, 2026, 1:09 PM ET / 17:09 UTC. ClawSweeper reviewWhat this changesThis PR deletes the unreachable, disabled Station prototype and its roadmap pages, then documents Crabbox as a remote execution-and-evidence layer rather than an in-box agent-runtime host. Merge readinessKeep this PR open for an explicit product-direction decision. The code removal appears technically sound and is supported by real CLI proof, but it also removes the only in-repository Station and agent-runtime contract while both linked proposals remain open. Priority: P2 Review scores
Verification
How this fits togetherCrabbox callers acquire remote leases, execute commands or jobs, and receive logs, artifacts, status, and cleanup evidence. Station was a proposed layer above leases for durable supervised workloads and an eventual agent-runtime bridge. flowchart LR
Caller[Developer, CI, or agent] --> CLI[Crabbox CLI]
CLI --> Lease[Remote lease]
Lease --> Run[Command or job execution]
Run --> Evidence[Logs, artifacts, status]
Station[Proposed Station layer] --> Lease
Station --> Runtime[Long-running harness]
Scope[Vision and docs] --> Caller
Decision needed
Why: The branch is technically coherent, but it changes the repository’s future product and security boundary rather than only deleting an unused implementation seam. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Either explicitly reject the Station and in-box harness direction and close or redirect the two linked proposals, or retain their roadmap and security-contract documentation until maintainers select a successor design. Do we have a high-confidence way to reproduce the issue? Not applicable: this PR removes an unreachable disabled package and changes product documentation rather than addressing a current runtime bug. The submitted terminal proof does demonstrate the intended absence of a Is this the best way to solve the issue? Unclear: removing unreachable code is a narrow solution, but removing the linked roadmap and security contract is not the best resolution until maintainers decide whether the open product direction is rejected or merely deferred. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning high; reviewed against f7c915578a6c. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Summary
internal/stationpackage. It was unreachable dead code: no package imported it, no CLI command exposed it, and its default feature gate rejected every phase as not yet enabled.VISION.mdframing and entire Lifecycle Safety section verbatim, then add the product boundary for remote execution, evidence, quality, non-goals, and autonomous contributions around it. The vision change is additive to the maintainer-authored safety policy.Scope boundary
The original
VISION.mdLifecycle Safety rules remain word-for-word identical tomain, including exact ownership proof, conflict-safe adoption, fail-closed lifecycle behavior and claim metadata, and zero-residue live proof for funded or remote providers.The additive agent boundary says:
The explicit non-goals include:
Verification
gofmt -w $(git ls-files '*.go')— clean.go vet ./...— exit 0 locally.go test -race ./...— exit 0 on configured Blacksmith Testboxtbx_01kyq9mz4jtdn33f49t1457ngy; hosted run: https://github.com/openclaw/crabbox/actions/runs/30468595344The local runner exhausted temporary disk while linking the race suite. The final hosted run used a private runner home/config with normal
022file semantics so the permission-hardening fixtures exercised their intended modes.scripts/check-docs.sh— exit 0 after the review fixes.node scripts/build-docs-site.mjs—built docs site: dist/docs-site.diff -u <(git show origin/main:VISION.md) <(sed -n '1,10p' VISION.md)— no output; the original vision block is preserved verbatim.Exhaustive searches for
station,Station,station-profiles,agent-runtime-bridge,stationProfile,modelAccess, andModelAccessfound no legacy references. The additive VISION non-goals intentionally describe agent-runtime supervision and model credentials in plain language.Structured autoreview after the review fixes: clean, no accepted or actionable findings.
Real binary proof:
Related issues