Repository navigation
fix(web): keep sidebar controls visible with long workspace names - #286
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 7, 2026, 1:21 AM ET / 05:21 UTC (Revision 2). ClawSweeper reviewWhat this changesThe PR constrains the sidebar width so long workspace and account names truncate while controls remain visible, adds browser regressions, and updates embedded assets, documentation, and the changelog. Merge readiness✅ Ready for maintainer review This PR remains useful: main and v0.7.0 still have the clipping defect. The inspected patch and before/after browser proof support landing it without additional review blockers. Priority: P2 Review scores
Verification
How this fits togetherClickClack’s sidebar displays workspace and account names alongside channel and direct-message navigation. Its layout determines whether users can reach creation and collapse controls on desktop and mobile. flowchart TD
A[Workspace and account names] --> B[Sidebar grid]
B --> C[Constrained column width]
C --> D[Existing name truncation]
C --> E[Visible navigation controls]
E --> F[Creation dialogs and sidebar collapse]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Root-cause clusterRelationship: Members:
Proposal only: this assessment does not dispatch repair, suppress jobs, mutate sibling items, close, or merge anything. Technical reviewBest possible solution: Keep the existing truncation and control behavior, with a zero-minimum sidebar grid column across desktop and mobile layouts. Do we have a high-confidence way to reproduce the issue? Yes: long names encounter an unconstrained implicit grid column on main, matching the inspected before image and reported browser measurements. This read-only review did not execute the application. Is this the best way to solve the issue? Yes: constraining the existing grid column is a narrow repair that enables existing ellipsis styling and preserves control behavior. AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning medium; reviewed against 94e3b719f49c. LabelsLabel changes: No label changes. Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Constrain the sidebar grid column so existing label truncation preserves reachable creation controls. Fixes openclaw#284. Co-authored-by: Isaiah Knight <323176659+isaiahknight-va@users.noreply.github.com>
cfda5b8 to
307307a
Compare
|
Fixed in #286, merged as d59e804. Thanks @isaiahknight-va and @NOLXII. The labels already had ellipsis rules; the implicit grid column was expanding past the sidebar’s fixed width. Constraining it to On unchanged production CSS, Inspected synthetic Chromium proof: |


Fixes #284.
Long workspace or account names let the sidebar’s implicit grid column grow beyond the sidebar, clipping Create channel, Start direct message, and collapse controls. Constrain that column with
minmax(0, 1fr)so the existing ellipsis rules work. Row layout and permissions are unchanged.The candidate includes browser regressions, regenerated embedded assets, documentation, and an Unreleased entry. Thanks @isaiahknight-va for the repair and @NOLXII for the report.
Validation on AWS Crabbox: unchanged production CSS failed all three long-name cases (desktop workspace, mobile drawer, desktop account), while the short-name control passed. All four cases pass after the fix, including bounding-box checks, hit testing, actual dialog opening, truncation, and overflow assertions. Full
pnpm checkpassed. Independent Codex review is scoped-clean through P2, including the embedded assets. Exact-head GitHub CI is required before merge.The before/after images below were captured from the built app in Chromium with synthetic Northwind/Local Captain data and inspected before upload. These are automated Chromium captures against a disposable test instance; they do not claim interactive Electron validation.