Repository navigation
build: sign macOS server releases and refresh dependencies - #280
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed October 1, 2026, 12:06 AM ET / 04:06 UTC (Revision 2). ClawSweeper reviewWhat this changesThe branch adds signed and notarized macOS server packaging and publication checks, updates five dependencies and embedded browser assets, and prepares the 0.7.0 changelog. Merge readiness✅ Ready for maintainer review The release correction remains useful: current main still builds Darwin server archives through GoReleaser without this signing path. No concrete introduced defect was found, and the repository-state MEMBER classification also prevents automatic closure. Likely related people: steipete, with high-confidence routing from prior release work. Priority: P2 Review scores
Verification
How this fits togetherClickClack's release pipeline turns tagged server and desktop source into downloadable installers and archives. Local macOS signing produces draft assets that a clean GitHub runner verifies before the release becomes public. flowchart TD
A[Signed release tag] --> B[Local macOS packaging]
B --> C[Foundation signing]
C --> D[Apple notarization]
D --> E[Draft release assets]
E --> F[Clean runner verification]
F --> G[Public release]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep macOS server signing in the existing local release process and require the clean-runner verification to succeed before publication. Do we have a high-confidence way to reproduce the issue? Not applicable to a reproduced runtime bug: source inspection establishes the existing unsigned server-release path, but this read-only review did not execute macOS packaging. Is this the best way to solve the issue? Yes. Extending the existing Foundation signing process and preserving publication verification is a coherent solution; no concrete introduced defect was found. AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning medium; reviewed against 975ee58c1fc7. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (1 earlier review cycle)
|
Make every macOS release artifact use the Foundation Developer ID and require notarization before publication. The existing GoReleaser server archives had ad-hoc signatures; the desktop app was already signed. The local signed-tag macOS packaging command now also builds and signs both server architectures, submits them to Apple, and records checksums and submission receipts. GoReleaser excludes Darwin to preserve those draft assets. A clean macOS runner verifies the Foundation identity, hardened runtime, explicit notarization requirement, architecture, and macOS 13 server minimum. The desktop minimum remains macOS 12.
This also refreshes SQLite to 1.60.0, Virtua to 0.52.8, Wrangler to 4.143.0, oxfmt to 0.71.0, and oxlint to 1.86.0, rebuilds embedded web assets, and prepares the 0.7.0 changelog for the roaming feature in #260. The dependency cooldown and runtime floors remain intact. Every existing changelog bullet is preserved, with an empty Unreleased section above 0.7.0.
Validation:
pnpm check,pnpm coverage(86.7%), and 44 focused channel-order/chat Playwright tests passed on the dependency update.pnpm check, shell syntax checks, andgoreleaser check.codesign --check-notarization -R=notarized.Final signed artifacts will be built from the release tag and verified again locally and on the clean macOS runner. Publication remains gated on that verification.