build(deps): refresh scanner runtime and toolchains - #59
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 22, 2026, 5:45 AM ET / 09:45 UTC. ClawSweeper reviewWhat this changesUpdates bundled scanner and judge tools, moves the Docker runtime to Node.js 24, raises the Go requirement to 1.27.1, and refreshes dependency and GitHub Action pins. Merge readiness⛔ Blocked before merge - 2 items remain The refresh remains useful: current main and v0.1.8 retain the older dependencies. No concrete patch defect was found, but the reported runtime validation needs inspectable output before merge. Priority: P2 Review scores
Verification
How this fits togetherClawScan runs external scanners and judge commands inside its bundled Docker runtime and collects their reports. The changed build configuration supplies those tools and the workflows that build, analyze, and publish the project. flowchart LR
A[Skill files] --> B[ClawScan adapters]
C[Updated Docker runtime] --> B
B --> D[Scanner JSON reports]
D --> E[Run artifacts and optional judge]
F[Build and release workflows] --> C
Before merge
Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Retain this focused dependency refresh with documented source-build prerequisites and inspectable evidence that the updated image runs the existing scanner adapters. Do we have a high-confidence way to reproduce the issue? Not applicable: this is dependency maintenance, and no concrete existing-behavior bug is alleged or established. Is this the best way to solve the issue? Yes: updating the existing pins and prerequisite documentation is the narrow approach, and inspection found no competing implementation or concrete regression. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against b3b45886ae45. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Refresh the bundled scanner and command-line tools, update Go to 1.27.1 and x/text to 0.42.0, and align the Docker runtime with CI’s Node.js 24 LTS. Keep the packaged CLI’s Node.js >=18 requirement. Refresh Docker, Pages, and CodeQL Action pins to their current patch/minor releases; other Action majors are already current.
The Go module files were regenerated with Go’s package manager. Registry engine requirements support Node 24, and SkillSpector stays on the latest stable tagged release, 2.11.2.
Validation: full Go tests and vet, all npm/script tests, universal npm pack/install/CLI smoke, and an initial Docker build plus executable probes passed on AWS Crabbox. Independent Codex review is clean through P2. The final Node 24 image and real ClawScan scanner-adapter smoke are checked before merge, followed by exact-head CI including the multi-platform runtime image build.
Final Node 24 validation passed: the Docker image built successfully, all bundled tool version/help probes passed, and ClawScan ran both SkillSpector and Cisco against a synthetic skill through the Docker adapter with both scanner statuses
completed. No provider credentials were used. The initial smoke attempt had a temporary binary/report-directory name collision in the test harness; distinct paths fixed the harness and the rerun passed.