Repository navigation
fix(fusion): allow counterbalanced pair arm order - #1046
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesAdds an explicit starting-arm offset to Fusion benchmarks and retains it in single-block and repeated analysis. Example: Run a single-task matched-handoff block with FUSION_PAIR_ARM_OFFSET=1.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR provides useful benchmark control absent from current main, with no actionable correctness or security findings. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherOffline Fusion tooling consumes qualified repair tasks and explicit model budgets, executes comparison arms, writes accounting receipts, and analyzes settled results. flowchart LR
A[Qualified tasks and configuration] --> B[Pair benchmark runner]
B --> C[Ordered comparison arms]
C --> D[Provider calls and repair grading]
D --> E[Pair receipts and spending ledger]
E --> F[Single or repeated analysis]
Technical reviewBest possible solution: Retain the focused offset implementation, legacy receipt compatibility and documented requirement to predeclare comparison schedules. Do we have a high-confidence way to reproduce the issue? Current main computes arm order from the task index alone; a one-task manifest therefore starts every repeated block with cheap, and exposes no block offset. Is this the best way to solve the issue? The change extends the existing rotation owner with one validated value and additive receipt metadata, preserving scoring, accounting and default behavior. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 43d978e80dfa. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 1:40 PM ET / 18:40 UTC. |
8b8ef1a to
642620b
Compare
Summary
A repeated single-task Fusion comparison always ran its arms in the same order, even though the runner rotated across different tasks. Add an explicit zero-based arm offset so predeclared repeated blocks can use different starting arms. Preserve canonical strategy labels and default ordering.
Receipts and analysis retain offsets; legacy receipts use zero. Repeated analysis permits different offsets while continuing to require matching model/scoring protocols and consecutive spending ledgers. The offset is validated before any provider preflight or output creation.
Verification
Deployment and risk
Benchmark scripts only; no deployment or default routing change. No paid calls, budget changes, retries or scoring changes. Rotation does not eliminate all cache and order effects; schedules must be declared before inference.
Rebased onto the landed probe-qualified handoff and fresh Azure task. Both sets of regression tests are retained; the final rebased patch passed independent P0–P2 review. Fresh CI applies to the new head.