Repository navigation
test(fusion): add native speech retirement confirmation task - #1045
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesAdds a historical Azure speech cleanup repair task and documents its acceptance criteria and evaluation limits. Example: Benchmarking cancellation while an Azure speech response still owns a 32 MiB capacity lease.
Review scores
ProductKind: Test only · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR adds a distinct, focused benchmark task, and the reviewed patch introduces no actionable defects. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe offline Fusion harness consumes pinned workload manifests, exposes restricted historical source to repair agents, and grades their edits against isolated historical acceptance tests. flowchart LR
A[Workload manifest] --> B[Historical source fixture]
B --> C[Visible tests and source context]
C --> D[Restricted repair agent]
D --> E[Isolated acceptance verifier]
E --> F[Qualification and evaluation receipts]
Technical reviewBest possible solution: Land the focused workload addition once the existing hosted qualification completes successfully, retaining its development-data and no-efficacy-claim limits. Do we have a high-confidence way to reproduce the issue? This PR adds evaluation coverage rather than repairing current main; the historical source and acceptance-test diff substantiate the declared cleanup failure. Is this the best way to solve the issue? The manifest reuses the existing qualification, source-context, edit restriction, and verifier owners without adding parallel machinery. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 43d978e80dfa. Provenance checked
TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 1:39 PM ET / 18:39 UTC. |
Summary
Add an unexposed historical native Azure speech repair for prospective Fusion handoff confirmation. The task covers reader/capacity retention during invalid-header cleanup, caller abort and rejected asynchronous cancellation, including reentrant abort. Only the native speech module is editable; the existing retirement interface is available as context.
Verification
Deployment and risk
No model calls or runtime changes. No benchmark efficacy claim. This task remains unexposed and must not be described as held-out confirmation after using its acceptance results to tune a policy. Full hosted corpus qualification is required before landing.