Repository navigation
test(fusion): add stream and lifecycle repair workloads - #1040
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesAdds two pinned historical repair workloads for Gemini SSE negotiation and managed-job observation loss, with qualification documentation. Example: A coordinator selects the gemini-sse-negotiation benchmark.
Review scores
ProductKind: Test only · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR adds distinct benchmark coverage absent from current main; no actionable defect was found. Priority: P3 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherFusion's offline benchmark harness consumes pinned task manifests, presents editable source and visible tests to repair agents, and grades submitted repairs with separate acceptance tests. flowchart TD
Manifest[Workload manifest] --> Qualification[Baseline and reference qualification]
Qualification --> Agent[Repair agent]
Agent --> Visible[Visible tests]
Agent --> Repair[Submitted source repair]
Repair --> Acceptance[Isolated acceptance tests]
Acceptance --> Receipt[Benchmark receipt]
Technical reviewBest possible solution: Land the focused corpus extension once its existing qualification check succeeds. Do we have a high-confidence way to reproduce the issue? This is a benchmark addition rather than a current bug report; pinned source contracts and acceptance tests were inspected without executing target code. Is this the best way to solve the issue? The existing manifest and qualification machinery provide the smallest complete extension, with explicit API requirements and separate acceptance tests. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 1f12686c1448. TestingProof path: in-process harness. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 12:57 PM ET / 17:57 UTC. |
Adds two qualified historical repair workloads for Gemini SSE negotiation and durable managed-job observation loss. The instructions define required wire behavior and new positional API arguments before inference; acceptance tests remain outside the repair loop.
Verification: Gemini passes 12 original tests on both revisions, with 2 baseline failures out of 15 acceptance tests; the reference passes 15/15. Managed observation loss passes 10 original tests on both revisions, with 10 baseline failures out of 21; the reference passes 21/21. Every baseline failure is an assertion, with no skips or cancellations. Workload/local-runner checks: 31 passed, three optional Docker checks skipped. Independent P0–P2 review found no actionable issues.
Deployment: none. This changes benchmark manifests, documentation and the qualification job timeout. These are coordinator-selected development tasks; qualification does not establish model quality or a fusion gain. No routing defaults change.
Hosted qualification passed every corpus at the original head, then the job exceeded its 25-minute limit during the final isolated candidate checks. Raise the job allowance to 35 minutes without removing tests or changing individual test deadlines. The timeout follow-up passed independent P0–P2 review. Fresh full CI is required before landing.