Skip to content

fix(fusion): select agent time in pair analysis - #1038

Merged
vincentkoc merged 1 commit into
mainfrom
fix/fusion-analysis-agent-latency-20261114
Nov 13, 2026
Merged

vincentkoc merged 1 commit into
mainfrom
fix/fusion-analysis-agent-latency-20261114

Conversation

@vincentkoc

@vincentkoc vincentkoc commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Adds an explicit agentElapsedMs option to Fusion pair analysis. A cold acceptance grade can otherwise reverse the apparent latency ranking; selected agent time now drives ratios, cheap dominance and repeated pilot checks consistently. Legacy elapsedMs remains the default, both totals are retained, and missing agent measurements never fall back to total time.

Verification: 89 focused pair-analysis/runner tests passed, one optional Docker test skipped. The three new analysis regressions fail against the original source. Replay of the completed controlled run reports cheap dominance and a mixed/strong agent-time ratio of 0.7980. Independent source review found no actionable P0–P2 issues.

Deployment: none. No inference or production routing changes. Remaining risk: selecting a different metric changes comparative interpretation; reports identify the metric and documentation requires choosing it before comparison.

@clawsweeper

clawsweeper Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. P2 Normal priority bug or improvement with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. and removed clawsweeper:intake:bug Preliminary submission classification; full source review pending. clawsweeper:intake:needs-repro Preliminary submission classification; full source review pending. labels Nov 13, 2026
@clawsweeper

clawsweeper Bot commented Nov 13, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

Adds explicit agent-time selection to Fusion pair analysis while preserving total elapsed time as the default.

Example: Equal-quality arms have cheap agent/total times of 36/82 ms, strong times of 69/70 ms, and candidate times of 55/56 ms.

  • Before: Total-time analysis says cheap does not dominate the candidate.
  • After: Selecting agentElapsedMs identifies cheap dominance and reports a candidate/strong latency ratio of 55/69.

Review scores

Measure Result What it means
Overall readiness 🦐 gold shrimp (3/6) Focused, useful implementation with meaningful regression coverage and passing script CI; independently inspectable execution evidence is limited.
Proof confidence 🦐 gold shrimp (3/6) This maintainer-authored PR is outside the contributor proof gate; its body reports a controlled-run replay, but attaches no inspectable terminal output or artifact, so that replay is not independently verified.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Feature · Worth it: Yes · Fix scope: Complete
User problem: Researchers cannot directly exclude independent acceptance grading when comparing agent execution latency.
Reason: Maintainer authorship establishes direction, and explicit selection makes existing measurements usable without replacing the documented default.

Merge readiness

✅ Ready for maintainer review

Keep open: this maintainer-authored PR adds useful analysis capability absent from current main, with no actionable correctness or security findings.

Priority: P2
Reviewed head: ad4268cd04634d5d2d96adc63d40adf3183595a2

Before merge

None.

Findings

None.

Agent review details

How this fits together

The offline analyzer reads settled benchmark JSON receipts and produces quality, cost, latency, dominance, and repeated-pilot summaries; production routing is unaffected.

flowchart LR
  A[Paired benchmark runner] --> B[JSON receipts]
  B --> C[Analysis CLI]
  D[Selected latency metric] --> C
  C --> E[Consistency validation]
  E --> F[Comparison summaries]
Loading

Technical review

Best possible solution:

Keep metric selection in the existing analyzer, preserving legacy totals and using the selected measurement consistently.

Do we have a high-confidence way to reproduce the issue?

Source establishes the limitation: current main uses total elapsedMs even though the runner records separate phase timings, allowing slow grading to reverse an execution-time ranking; no target code was executed.

Is this the best way to solve the issue?

The focused extension fits the existing owner and preserves compatibility: callers opt in, both totals remain visible, and unavailable agent measurements cannot silently become total time.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against ee1626510f59.

Provenance checked

  • Single-run and repeated latency comparisons keeps the original intent (a1772b0: Compare complete matched blocks with consistent accounting and a fixed exploratory quality, cost, and latency screen.)
  • Phase timing and default analysis semantics keeps the original intent (f0e33cf: Separate independent grading from agent execution while retaining end-to-end elapsedMs and requiring metrics to be chosen before comparison.)

Testing

Proof path: unit tests only.

Security

None.

Evidence

What I checked:

Likely related people:

  • Vincent Koc: Raw commit a1772b0 adds scripts/fusion-pair-analysis.mjs:16 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: a1772b0e3d76; files: scripts/fusion-pair-analysis.mjs)

Preflight source

Source unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified.

Labels

Label changes:

  • add P2: Improves offline benchmark interpretation without changing inference, routing, or existing analysis defaults.
  • add rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P2: Improves offline benchmark interpretation without changing inference, routing, or existing analysis defaults.
  • rating: 🦐 gold shrimp: Overall readiness is 🦐 gold shrimp; proof is 🦐 gold shrimp and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed November 13, 2026, 11:44 AM ET / 16:44 UTC.

Base automatically changed from fix/fusion-complete-adviser-responses-20261114 to main November 13, 2026 17:08
@vincentkoc
vincentkoc force-pushed the fix/fusion-analysis-agent-latency-20261114 branch from ad4268c to 9e1740c Compare November 13, 2026 17:09
@vincentkoc
vincentkoc marked this pull request as ready for review November 13, 2026 17:09
@vincentkoc
vincentkoc merged commit f82ffc0 into main Nov 13, 2026
19 of 20 checks passed
@vincentkoc
vincentkoc deleted the fix/fusion-analysis-agent-latency-20261114 branch November 13, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🦐 gold shrimp Decent PR readiness signal, but merge confidence is limited. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant