Repository navigation
fix(fusion): select agent time in pair analysis - #1038
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesAdds explicit agent-time selection to Fusion pair analysis while preserving total elapsed time as the default. Example: Equal-quality arms have cheap agent/total times of 36/82 ms, strong times of 69/70 ms, and candidate times of 55/56 ms.
Review scores
ProductKind: Feature · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this maintainer-authored PR adds useful analysis capability absent from current main, with no actionable correctness or security findings. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherThe offline analyzer reads settled benchmark JSON receipts and produces quality, cost, latency, dominance, and repeated-pilot summaries; production routing is unaffected. flowchart LR
A[Paired benchmark runner] --> B[JSON receipts]
B --> C[Analysis CLI]
D[Selected latency metric] --> C
C --> E[Consistency validation]
E --> F[Comparison summaries]
Technical reviewBest possible solution: Keep metric selection in the existing analyzer, preserving legacy totals and using the selected measurement consistently. Do we have a high-confidence way to reproduce the issue? Source establishes the limitation: current main uses total elapsedMs even though the runner records separate phase timings, allowing slow grading to reverse an execution-time ranking; no target code was executed. Is this the best way to solve the issue? The focused extension fits the existing owner and preserves compatibility: callers opt in, both totals remain visible, and unavailable agent measurements cannot silently become total time. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against ee1626510f59. Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 11:44 AM ET / 16:44 UTC. |
ad4268c to
9e1740c
Compare
Adds an explicit agentElapsedMs option to Fusion pair analysis. A cold acceptance grade can otherwise reverse the apparent latency ranking; selected agent time now drives ratios, cheap dominance and repeated pilot checks consistently. Legacy elapsedMs remains the default, both totals are retained, and missing agent measurements never fall back to total time.
Verification: 89 focused pair-analysis/runner tests passed, one optional Docker test skipped. The three new analysis regressions fail against the original source. Replay of the completed controlled run reports cheap dominance and a mixed/strong agent-time ratio of 0.7980. Independent source review found no actionable P0–P2 issues.
Deployment: none. No inference or production routing changes. Remaining risk: selecting a different metric changes comparative interpretation; reports identify the metric and documentation requires choosing it before comparison.