Repository navigation
test(fusion): add complete-adviser repair workload - #1037
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs changes before merge. What this changesAdds a pinned Fusion adviser-completion repair workload and documents a cheap-model, strong-model, and handoff comparison. Example: Benchmarking an adviser response with finish_reason="length" and usable text.
Review scores
ProductKind: Test only · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Needs changes before merge - 1 item remains Keep open: this maintainer-authored draft adds a focused benchmark task absent from main, with appropriately limited conclusions and no actionable correctness findings. Priority: P3 Before merge
FindingsNone. Agent review detailsHow this fits togetherThe offline Fusion benchmark loads pinned repository revisions, exposes permitted source and visible tests to repair agents, and evaluates their edits against separate acceptance tests. flowchart LR
A[Pinned workload manifest] --> B[Qualification runner]
B --> C[Isolated repair agent]
C --> D[Permitted source edits]
D --> E[Acceptance verifier]
E --> F[Benchmark results]
Technical reviewBest possible solution: Land the runtime dependency, then retain this focused development workload with its explicitly limited benchmark conclusions. Do we have a high-confidence way to reproduce the issue? This PR adds benchmark coverage; the underlying incomplete-adviser path is source-verifiable on main and is repaired separately. Is this the best way to solve the issue? The manifest reuses existing qualification and isolation owners, limits edits to the collector, and avoids adding benchmark machinery or changing routing policy. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against ee1626510f59. TestingProof path: none. SecurityNone. EvidenceWhat I checked:
Likely related people:
Preflight sourceSource unknown. Source comparison at the observed PR snapshot only. Completion is self-reported; body, policy, tests, execution, and report bytes are not verified. LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed November 13, 2026, 11:44 AM ET / 16:44 UTC. |
7443d3e to
46e2a31
Compare
Adds a pinned development repair for incomplete Fusion adviser responses and records a controlled cheap/strong/handoff comparison. All three solved this case; cheap-only was fastest and least expensive, so the result does not support a fusion quality gain.
Verification: original and reference pass three visible tests; original fails 11 of 26 acceptance checks and reference passes all 26 without skips. The exact manifest matches the qualified receipt. Existing workload/local-runner tests: 31 passed, three optional Docker tests skipped. Independent source review found no actionable P0–P2 issues. The 28-call controlled run settled all usage; results report agent time separately from cold grading.
Deployment: none. No routing defaults change. Remaining risk: one coordinator-selected development task cannot establish generalization or production readiness.