feat: review and publish 16-item Featured selections from monthly installs - #3765
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Autoreview closeout: two review cycles, followed by direct owner/dependency inspection and native proof.
Direct dependency sources: https://github.com/get-convex/convex-backend/blob/86001446/crates/isolate/src/environment/udf/async_syscall.rs and https://github.com/get-convex/convex-backend/blob/86001446/crates/database/src/query/index_range.rs. The lead personally inspected these and the installed Convex SDK contract. |
ClawHub UI ProofStatus:
Full videos: Raw proof files: https://github.com/openclaw/clawhub/tree/qa-artifacts/clawhub-ui-proof/pr-3765/featured-sixteen |
|
Codex review: blocked before merge. Reviewed September 16, 2026, 4:48 PM ET / 20:48 UTC. ClawSweeper reviewWhat this changesAdds editable staff reservations, monthly install ranking, and audited publication of 16 Featured plugins and skills through the dashboard, API, and staff CLI. Merge readiness⛔ Blocked before merge - 4 items remain Keep open: this adds meaningful capability absent from main, and no blocking code defect was established. The remaining gate is coordinating the digest receiver rollout. Priority: P2 Review scores
Verification
How this fits togetherClawHub’s Featured workflow turns catalog eligibility, recorded installs, and staff choices into reviewable selections. Approved publication updates catalog badges, while a separate weekly digest sends recommendation evidence to Hermit. flowchart TD
A[Daily install records] --> C[Monthly ranking and eligibility]
B[Staff editorial reservations] --> C
C --> D[Saved recommendation report]
D --> E[Staff approval and current checks]
E --> F[Featured badges and publication audit]
C --> G[Weekly digest]
G --> H[Compatible Hermit receiver]
Decision needed
Why: Receiver deployment is an external release dependency that source inspection and local proof cannot establish. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Retain the shared report and badge owners, deploy the compatible receiver first, and coordinate the current-checkout staff CLI with the backend upgrade. Do we have a high-confidence way to reproduce the issue? Not applicable to the feature request; native publication receipts and browser screenshots demonstrate the added workflow. Is this the best way to solve the issue? Yes, with coordinated rollout: extending the shared report and badge owners avoids a competing publication path; automatic publication or a source-coded editorial list would violate the documented review model. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 7725f32bf07d. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
The receiver rollout dependency is satisfied. Hermit #47 merged at The operator is using the built staff CLI from current tested checkout Exact-head CI passed for all three ClawHub layers: intelligence, public order, homepage. Publication remains separate from deployment and requires the saved reviewed report plus a fresh eligibility check. |




What Problem This Solves
Staff need a complete, explainable Featured proposal: 16 plugins and 16 skills, with editable editorial plugin reservations and the remaining places ranked by recorded adoption.
User Impact
Plugins reserve eight staff-selected entries first and recommend eight distinct eligible entries by installs over 30 completed UTC days; skills recommend 16. Final-seven-day installs then stable identity break ties. Search demand remains separate context. Missing editorial entries stay pending without public links or replacement candidates. Neither recomputation nor editing publishes a selection.
Why This Change Was Made
One stored selection owner provides editorial revision checks, audited publication, and a consistent 16-item capacity. The staff API and CLI publish only the exact ordered identities, versions, reasons, and counts from a completed saved recommendation report, then recheck current eligibility in the publication transaction. Dry runs preserve badges, audit state, and digest state. Publishing currently requires all 16 entries to be ready; three approved editorial entries are still awaiting canonical public releases.
Monthly collection scans the complete positive install population before ranking, with no search, download, incumbent Featured, or publisher bonus. Existing category and security eligibility remain. The dashboard and versioned digest expose counts, periods, capture times, imported-data provenance, pending reasons, and proposed removals. Deploy the compatible Hermit receiver before the v4 sender.
Evidence
At combined stack head
19695a845b7d925714b05e58ff1f50c055f5b7d9: 7,070 unit tests passed (3 skipped), static/audit, full types/build, packages, HTTP/CLI e2e, all three explicit package/Convex type checks, and 19 Chromium smoke tests passed.Native local Convex plus the real built staff CLI published exact 16-item fixture sets for both catalogs. Twenty altered-evidence, expired-report, changed-version, and stale-publication cases rejected without changing protected state. The accepted autoreview finding about caller-supplied evidence was reproduced before the repair and fixed by authoritative saved-report binding.
Real React/Convex browser proof covers editable reservations, stale-report refresh, 13-ready/3-pending plugins, 16 skills, empty install evidence, and desktop/laptop/tablet/mobile views. No production writes or digest sends occurred. The original baseline fixture has fewer candidates, so those screenshots establish the expanded behavior rather than a controlled ranking comparison. Same-input mobile and public-order regressions have paired failing/passing proof.
An independent read-only production census matched every count in the approved frozen Aug 17–Sep 16 snapshot: 24,140 raw plugin-day rows and 2,220,978 raw skill-day rows; 1,430 and 9,230 nonzero rows, with no duplicate artifact/day pairs or differences. Counts represent recorded install events, not unique users or confirmed successful runtime installs.
The capture uses multiple query snapshots, with explicit collection start/end times. It does not promise an atomic database snapshot across late historical corrections. Saved reports freeze reviewed evidence; publication rejects changed payloads and current ineligibility.
Production +1,803/-461 (net +1,342); tests/fixture support +1,105/-557; generated schema/API +74/-2; docs +107/-19. Growth supplies persistent editable selection ownership, authenticated audited publication, complete monthly aggregation, and staff review surfaces; the prior weighted recommendation path is removed.
Real browser and native publication proof.