feat: recommend complete Featured lineups for both catalogs - #3726
Patrick-Erichsen merged 2 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bd88ed5 to
ea41d09
Compare
ClawHub UI ProofStatus:
Raw proof files: https://github.com/openclaw/clawhub/tree/qa-artifacts/clawhub-ui-proof/pr-3726/claw724-bd88ed5 |
|
Codex review: blocked before merge. Reviewed September 15, 2026, 11:18 PM ET / September 16, 2026, 03:18 UTC. ClawSweeper reviewWhat this changesProposes complete eight-item Featured selections for plugins and skills, including retained entries, additions, removals, and unfilled slots across the dashboard, API, CLI, and weekly digest. Merge readiness⛔ Blocked before merge - 3 items remain This remains a useful, distinct contribution: current main provides shortlists rather than complete Featured lineups. The collaborator-authored PR has convincing browser evidence and no blocking code finding. Priority: P2 Review scores
Verification
How this fits togetherClawHub’s staff intelligence tools combine search demand, adoption snapshots, and current Featured membership into advisory recommendations. Staff review these recommendations, while Hermit receives the weekly digest for delivery. flowchart TD
A[Search demand] --> D[Recommendation builder]
B[Adoption snapshots] --> D
C[Current Featured membership] --> D
D --> E[Eligibility and eight-item selection]
E --> F[Staff dashboard and CLI]
E --> G[Frozen weekly digest]
G --> H[Hermit receiver]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep one shared advisory lineup builder, preserve frozen v1/v2 payloads, and coordinate v3 activation with verified receiver deployment and an accurate durable contract. Do we have a high-confidence way to reproduce the issue? Not applicable to a new recommendation capability; source comparison and captured browser runs establish the shortlist-to-complete-lineup change. Is this the best way to solve the issue? Yes, the shared recommendation owner is the appropriate layer; separate UI or digest ranking would create competing selections. The remaining specification correction is narrow. Full review comments:
Overall correctness: patch is correct AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 5bf0026d8f6f. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
ea41d09 to
2bb638f
Compare
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: feat: recommend complete Featured lineups for both catalogs This is item 1/1 in the current shard. Shard 0/1. This placeholder means the worker is alive and reading the current context. I will edit this same comment with the actual review when the claws are done clicking. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
















What Problem This Solves
The intelligence report lists shortlisted additions without proposing the complete eight-item Featured lineup or comparing it with the current selection.
User Impact
Every iteration proposes up to eight plugins and eight skills, with keeps, additions, removals, unfilled slots, supporting search/adoption evidence and freshness. Existing selections are reassessed; emerging labels use the existing New/Rising evidence. Dashboard, API, CLI and weekly digest share the same complete proposal.
Why This Change Was Made
Hydrate current membership independently of bounded search/Trending inspection and rank within each catalog using the existing evidence cohorts. Keep unknown evidence explicit, preserve query privacy, and never pad an incomplete lineup. A versioned v3 digest retains every selected item while compacting auxiliary evidence; deploy Hermit #45 before enabling its producer. Frozen v1/v2 contracts remain supported.
Recommendations remain advisory: the revised production lineup needs Patrick’s approval. This PR neither publishes Featured nor changes the homepage default.
Evidence
Before: current Featured members absent from inspected search/Trending could disappear from consideration; digest capped candidates at five. After: complete8 includes retained/add/remove partition and baseline, with explicit shortfall for an empty catalog. Registered Convex regression covers 101 unrelated Claws before current plugin membership. Actual authenticated UI at four viewport sizes shows the eight-item proposal; native report reads publish nothing, eighth grant succeeds, ninth fails and retain preserves timestamps. Comparable baseline/candidate browser artifacts are attached separately.
Native Monday-window reports passed through the real production digest builder and Hermit parser/Carbon renderer without delivery. Production +329 net lines for full-set recommendation/read/UI/wire behavior; tests/support +363, docs +18. Structured review and root owner-boundary review completed; discovered projection/unknown-evidence issues were corrected and verified.
Validation at the complete stack: static, 6,903 unit tests, types/build, package verification, and HTTP/CLI e2e all passed. Native Convex and authenticated browser checks use isolated labeled fixtures; production Featured and digest delivery remain unchanged.
Related: CLAW-724.
Review follow-up:
1dfa7198efupdates the existing weekly-digest and search-intelligence specifications for complete v3 lineups, compaction/failure semantics, legacy replay, cap transition and receiver-first deployment. Hermit #45 merged as911c819; its successful Cloudflare build identifies production Worker versionda09efd1-efc7-4275-be99-b4dab37b09d4. The live receiver accepted the deployed shared credential and returned expected GET 405 at 2026-09-16T03:21:18Z; no digest POST occurred. Cloudflare control-plane traffic percentage and D1 continuity were not re-read because its credentials are unavailable; neither the D1 binding nor receipt schema changed.