feat: make Featured the ClawHub homepage default - #3720
Patrick-Erichsen merged 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Patrick-Erichsen
changed the title
ClawHub UI ProofStatus:
Raw proof files: https://github.com/openclaw/clawhub/tree/qa-artifacts/clawhub-ui-proof/pr-3720/featured-homepage-default |
clawsweeper
Bot
added
P2
|
Codex review: needs maintainer review before merge. Reviewed September 16, 2026, 4:48 PM ET / 20:48 UTC (Revision 6). ClawSweeper reviewWhat this changesThe PR makes Featured the homepage’s initial server-rendered view, client fallback, and return-to-Skills view, with corresponding test updates. Merge readiness✅ Ready for maintainer review No blocking findings. Current main still defaults to Trending, so this PR remains useful. The September 16 approval resolves the previous editorial hold, and the inspected browser evidence supports the intended behavior. Priority: P2 Review scores
Verification
How this fits togetherClawHub’s homepage loads public skill and plugin listings through existing catalog feeds. The homepage component selects the initial feed and handles subsequent tab and catalog changes. flowchart TD
A[Homepage visit] --> B[Route loader]
B --> C[Existing Featured feed]
C --> D[Homepage listing]
E[Client fallback] --> D
D --> F[User selects catalog or tab]
F --> G[Featured or alternate catalog feed]
G --> D
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Use the existing Featured feeds consistently for homepage defaults while preserving explicit navigation and the separate audited publication workflow. Do we have a high-confidence way to reproduce the issue? Not applicable as a bug reproduction: this changes an intentional default, and current-main source plus before/after browser evidence establish the behavior difference. Is this the best way to solve the issue? Yes—the narrowest solution is to reuse Featured at the loader and component selection points; changing only the client would leave the first render inconsistent, while a new backend feed or configuration option would duplicate existing capability. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 7725f32bf07d. LabelsLabel justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (5 earlier review cycles)
|
639dded to
a5aa852
Compare
This comment has been minimized.
This comment has been minimized.
a5aa852 to
0c9098d
Compare
0c9098d to
19695a8
Compare
Patrick-Erichsen
changed the title
|
The September 16 owner decision resolves the prior acceptance hold: Patrick reviewed the first real production-data experiment and explicitly approved updating the Featured selections for both catalogs while retaining the homepage-default requirement. The PR description now reflects that approval and the dependent 16-item stack. Missing editorial packages remain pending and never become broken cards; production publication is separate and audited. Full combined-head checks and updated local native-browser proof are recorded in the body. @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. |
ClawHub UI ProofStatus:
Raw proof files: https://github.com/openclaw/clawhub/tree/qa-artifacts/clawhub-ui-proof/claw724-production-20260916 |
This branch was successfully deployed
1 participant
What Problem This Solves
The ClawHub homepage opens on Trending even after the staff-reviewed Featured selection is ready to be the first discovery view.
User Impact
Featured becomes the server-rendered first view, client fallback, and return-to-Skills view. Trending, Official, New, and direct catalog navigation remain available.
Why This Change Was Made
The existing Featured feeds now preserve approved publication order through the preceding stack layer. This layer changes the default only.
The earlier editorial-acceptance hold is resolved: Patrick reviewed the real production-data selection on September 16 and explicitly approved updating the 16-plugin/16-skill sets and retaining Featured as the homepage default. The shared intelligence pipeline was already deployed; this stack extends it with editable reservations and monthly install ranking. Production rollout and audited publication follow the stack, with missing editorial entries remaining pending and no broken public cards. Future selections still require approval.
Evidence
At
19695a845b7d925714b05e58ff1f50c055f5b7d9, the combined stack passed 7,070 tests (3 skipped), static/audit, types/build, package and HTTP/CLI checks, explicit package/Convex type checks, and 19 browser smoke cases.Real local React/Convex browser proof at desktop, laptop, tablet, and mobile widths shows Featured selected on first load and after returning to Skills, exact published order for both catalogs, and preserved Official/New/Trending direct navigation. The previous proof remains available below; the updated shared proof additionally exercises the 16-item publication contract. These are local runtime checks, not a claim that the new selection is already published in production.
Production +4/-13; tests +26/-12. No new configuration, backend query, persistence, or publisher path.
Real browser and native publication proof.