feat: include scoped skill demand in search intelligence - #3714
Patrick-Erichsen merged 4 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ClawHub UI ProofStatus:
Raw proof files: https://github.com/openclaw/clawhub/tree/qa-artifacts/clawhub-ui-proof/pr-3714/scoped-skill-demand |
|
Codex review: blocked before merge. Reviewed September 15, 2026, 4:10 PM ET / 20:10 UTC. ClawSweeper reviewWhat this changesAdds manual skill-search observations and catalog-versus-filtered-shelf reporting to staff dashboards, HTTP responses, and the admin CLI. Regression provenancePossible regression — suspected (reviewed change). No predecessor PR is attributed. Merge readiness⛔ Blocked before merge - 5 items remain This remains a useful extension beyond current main, with credible browser and upgrade evidence. The weekly digest still loses scope information, and the durable collection specifications need updating. Priority: P2 Review scores
Verification
How this fits togetherClawHub records bounded, anonymous search-result facts and aggregates them into staff demand reports. Those reports also feed advisory Featured suggestions and a weekly digest delivered through Hermit. flowchart TD
A[Manual skill or plugin search] --> B[Public search response]
B --> C[Bounded anonymous observation]
C --> D[Daily aggregates by catalog and scope]
D --> E[Staff dashboard and API and CLI]
D --> F[Weekly digest]
G[Current public catalog eligibility] --> E
F --> H[Hermit delivery]
Decision needed
Why: The current receiver cannot represent scope, and silently collapsing it changes the meaning of reported demand; choosing a temporary narrower digest changes operator-visible coverage. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Preserve scope through the weekly digest's validated, rendered contract while retaining legacy data, anonymous capture, and advisory-only recommendations. Do we have a high-confidence way to reproduce the issue? Yes, source establishes a deterministic PR-head case: give one query threshold-qualified catalog and shelf aggregates, then build the weekly digest; both rows survive but their scope does not. This review did not execute target code. Is this the best way to solve the issue? The shared capture and aggregation approach is appropriate and avoids a competing analytics store. The digest adaptation is incomplete because its serialized contract cannot express the new row identity. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against b5729e702ea8. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
|
The scope-loss finding and both Rank-up moves are resolved in the coordinated atomic stack through ClawHub #3718, with Hermit #44 already merged and deployed as receiver version 81. There will be no intermediate production deployment of this collection layer with the old live v1 builder. At combined head The requested regression at The real persistent Convex upgrade proof additionally verifies legacy weeks, new v2 production, restart continuity, and unchanged replay; its nine relevant source blobs match the current combined head: producer proof. Actual Discord posting stays unverified and is intentionally excluded from Patrick's first read-only production dry run. |




What Problem This Solves
Staff search intelligence currently sees plugin demand but misses manual skill searches and cannot distinguish a filtered shelf from the full catalog.
User Impact
Staff can filter the dashboard, API and CLI by plugins or skills and by catalog, shelf or legacy scope. Existing observations and aggregation state remain intact; historical rows keep unknown scope and do not establish catalog-wide company opportunities. Skill coverage begins when collection actually starts. Homepage skill shelf collection remains a separate follow-up.
Why This Change Was Made
The existing privacy-preserving observation store and aggregation cursor now handle both artifact kinds. Header, full search and native Skills searches consume one ephemeral intent per catalog; current metadata uses shared public visibility, security, installability and Featured ownership checks. The weekly plugin classifier only classifies catalog gaps. Suggestions remain advisory.
Connected regressions repaired: footer navigation could count the same intent again; a failed skill search could also display “No matches”; GitHub skills lacking an installable source could appear eligible.
Evidence
bun run ci:staticpassed with audit0;bun run ci:unit6845 passed,3 skipped;bun run ci:types-buildpassed. Package verification passed before the mechanical rebase; the four feature commits are identical by range-diff.Real screenshots and the detailed snapshot are attached in the UI proof comment. The proof uses disposable fixtures, not production demand.