fix(security): upgrade ClawScan and SkillSpector workers - #3658
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: blocked before merge. Reviewed September 10, 2026, 12:29 AM ET / 04:29 UTC. ClawSweeper reviewWhat this changesUpdates both ClawHub security workers to ClawScan 0.1.8 and SkillSpector 2.11.2, with matching workflow contract tests. Merge readiness⛔ Blocked before merge - 3 items remain The upgrade remains useful, but both workflows currently reference an unpublished ClawScan version and would stop before scanning. Current main retains the previous pins, and the collaborator-authored PR must remain open. Priority: P2 Review scores
Verification
How this fits togetherClawHub’s security workers inspect staged publications and queued artifacts using locally installed scanners. Their reports feed publication checks and stored security assessments. flowchart LR
A[Staged publications] --> C[Security workers]
B[Queued artifacts] --> C
D[Pinned scanner installation] --> C
C --> E[ClawScan and SkillSpector]
E --> F[Security reports]
F --> G[Publication checks and assessments]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Upgrade the host-installed SkillSpector while retaining published ClawScan 0.1.7; adopt 0.1.8 separately once its release is available. Do we have a high-confidence way to reproduce the issue? Yes for the installation defect: both workflows require 0.1.8, while npm’s complete package metadata omits that version. Installation and tests were not executed in this read-only review. Is this the best way to solve the issue? Acceptable upgrade direction, but the ClawScan bump is premature. Updating SkillSpector directly is the narrower solution because the intended upstream ClawScan change only affects Docker, which these workers disable. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 8455c30f7581. LabelsLabel changes:
Label justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
Update both security worker workflows to ClawScan 0.1.8 and SkillSpector 2.11.2 at the full immutable release SHA. ClawHub runs scanners outside Docker, so its independent SkillSpector installation must be upgraded as well as ClawScan. The old host pin resolves to SkillSpector 2.3.5; the new release includes the configurable 600-second workflow budget.
Update the existing workflow contract tests to match. The outer 15-minute worker timeout already accommodates the new scanner budget.
Validation
bunx vitest run scripts/security/prepublication-worker-workflow.test.ts scripts/security/security-scan-worker-workflow.test.ts: passed.bun run ci:static: passed.bun run ci:unit: 6,583 passed, 3 skipped.bun run ci:types-build: passed, including schema and CLI TypeScript checks.Live proof on
byungkyu/api-gateway@1.2.0, downloaded from the owner-qualified ClawHub API. Every published file matched its API SHA-256. The current export has 236 published files (the original 235 plus a generatedskill-card.md); export-only_meta.jsonwas excluded. All scans used--no-llmand an isolated environment with no model credentials.The timeout override works, and the default-budget run avoids runtime-limit/AE1 findings. The original 2.11.0 timeout did not reproduce on this Mac. The latest report remains partial with 186 unresolved-reference exceptions, one reference-extraction limit, and two obfuscated-text exceptions; it still reports 599 findings and CRITICAL / DO_NOT_INSTALL. This update does not claim to fix those independent scanner limits or ClawHub's completeness-reporting bug.
Packaged Linux/arm64 verification also passed using the built ClawScan 0.1.8 candidate and the complete runtime Dockerfile. The wrapper recorded SkillSpector 2.11.2 as
completed, preserving its raw partial report (99.2% coverage, no runtime-limit exceptions) in 65.94s. The same container stack with only SkillSpector reverted to 2.11.0 completed in 17.73s with 99.6% coverage and no runtime-limit exceptions. Both wrapper runs exited 0; SkillSpector itself exited 1 for findings. Neither result is presented as a clean or complete security scan.Published dependency verification
ClawScan 0.1.8 is now published. The previously pending npm dependency is available and installable:
This resolves the unpublished-package blocker in the initial automated review.