feat: deliver deterministic weekly search intelligence through Hermit - #3633
feat: deliver deterministic weekly search intelligence through Hermit#3633Patrick-Erichsen wants to merge 2 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex review: blocked before merge. Reviewed September 8, 2026, 7:19 PM ET / 23:19 UTC. ClawSweeper reviewWhat this changesAdds a scheduled weekly search-demand digest with advisory classification, persisted retry state, and authenticated delivery through Hermit. Merge readiness⛔ Blocked before merge - 5 items remain This remains distinct, useful work absent from current main. One token-fallback defect needs correction, and the collaborator-authored draft explicitly reserves rollout for human review. Priority: P2 Review scores
Verification
How this fits togetherClawHub turns aggregated plugin searches into weekly demand and curation leads. The producer freezes those facts in Convex and sends them to Hermit, which owns Discord delivery and durable duplicate suppression. flowchart LR
A[Search aggregates] --> B[Completed week reports]
C[Advisory classifier] --> D[Bounded frozen digest]
B --> D
E[Monday schedule and retries] --> D
D --> F[Authenticated Hermit receiver]
F --> G[Discord message and receipt]
G --> E
Decision needed
Why: The cron activates automatically, while the companion receiver is still a draft and the author explicitly reserves merge and deployment for human approval. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Preserve the shared reporting and frozen-payload design, normalize token fallback, and activate delivery only after the receiver and existing-database rollout are verified. Do we have a high-confidence way to reproduce the issue? Yes, for the patch defect: a whitespace-only CLAWHUB_HERMIT_TOKEN selects the wrong credential instead of a valid legacy fallback. This is source-proven; no runtime reproduction was executed. Is this the best way to solve the issue? The architecture is appropriate: reuse of canonical reports avoids competing counts, and Hermit retains Discord ownership. Token selection must match the receiver, and coordinated activation remains unproven. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 651a7641a204. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Build a deterministic Monday search-intelligence digest
Problem
Surface aggregate official gaps, Featured candidates, and weekly movement without sharing raw observations.
Change
Schedule Monday 09:00 Pacific delivery using completed UTC weeks. Only advisory intent classification uses a structured model with aggregate-only inputs. Persist shared classification and a frozen, bounded payload atomically; retries reuse it unchanged. All provenance, counts, ranking, and thresholds are deterministic.
Validation
Final integrated ClawHub suite: 6,582 passed, 3 skipped. Latest affected suite: 69 passed. Real Convex proof froze a 19-search completed-week payload and preserved dropped-to-zero movers. Independent review passed. Real Discord proof remains blocked by bot access error 50001.
Review status
Draft for human review. This is a dedicated search-intelligence stack, independent of the plugin-page/category work. No merge or production deployment is authorized.
The full integrated stack at
ca843a963apassedbun run ci:unit(6,582 passed, 3 skipped),bun run ci:types-build, package/HTTP/browser checks, and the non-audit static constituents.bun run ci:staticremains red on seven dependency advisories in the unchanged baseline lockfile; that repair is deliberately outside this stack. These results are from the saved reviewed head, not a claim that CI on this PR has passed.Real Discord delivery, duplicate receipt/readback, and Discord UI proof remain incomplete: the configured test bot receives HTTP 403 / Discord
50001 Missing Accessfor the intended channel. The preview and local tests are not production-delivery evidence.Related draft PRs
Review ClawHub bottom-to-top: capture → web attribution → dashboard/API/CLI → weekly producer.
Separate-repository companions: OpenClaw Control UI and Hermit receiver. The producer requires the Hermit receiver; the Control UI source marker requires the capture boundary. No plugin-page/category stack branches are included.