fix: tolerate docs corpus outages#1
Conversation
|
Codex review: needs maintainer review before merge. Reviewed June 7, 2026, 1:55 AM ET / 05:55 UTC. Summary Reproducibility: yes. from source inspection: current main awaits the docs corpus fetch without a catch, so a 503 or invalid corpus response aborts Review metrics: 2 noteworthy metrics.
Merge readiness Overall follows the weaker of proof and patch quality, so missing proof can cap an otherwise strong patch. Next step before merge
Security Review detailsBest possible solution: Merge the focused resiliency path after normal maintainer checks, keeping the docs search index primary with corpus compatibility fallback and a clear docs-unavailable workspace note. Do we have a high-confidence way to reproduce the issue? Yes from source inspection: current main awaits the docs corpus fetch without a catch, so a 503 or invalid corpus response aborts Is this the best way to solve the issue? Yes: preferring the smaller published docs index, falling back to the legacy corpus, and mounting an explicit docs-unavailable note is narrower than failing the whole chat request. The added smoke coverage targets the important runtime paths. AGENTS.md: found and applied where relevant. Codex review notes: model gpt-5.5, reasoning high; reviewed against 15fa3670959d. Label changesLabel changes:
Label justifications:
Evidence reviewedWhat I checked:
Likely related people:
What the crustacean ranks mean
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics. How this review workflow works
|
bd1055f to
72d00bf
Compare
|
@clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
|
Maintainer proof for current head Local gates run from Live export used the local OpenClaw docs/source/gitcrawl dataset: Runtime retrieval smoke proof: Autoreview rerun after the accepted fix: Also fixed one review edge while validating: relative @clawsweeper re-review |
|
🦞🧹 I asked ClawSweeper to review this item again. Re-review progress:
|
Summary
docs-search.jsonas the primary docs retrieval index so each chat request no longer depends on downloadingllms-full.txt.llms-full.txtand/.well-known/llms-full.txtas compatibility fallbacks when the search index is unavailable or cannot answer an otherwise empty workspace query.Related UI boundary PR: openclaw/docs#36.
Validation
npm run typechecknpm run lintnpm run format:checkASK_MOLTY_DOCS_REPO=... ASK_MOLTY_SOURCE_REPO=... ASK_MOLTY_GITCRAWL_DB=dist/gitcrawl-fixture.db ASK_MOLTY_OUT_DIR=dist/test npm run export && npm run smokegit diff --check