Skip to content

Add "fullscreen" button#1585

Open
Arnei wants to merge 4 commits into
opencast:r/20.xfrom
Arnei:fullscreen
Open

Add "fullscreen" button#1585
Arnei wants to merge 4 commits into
opencast:r/20.xfrom
Arnei:fullscreen

Conversation

@Arnei

@Arnei Arnei commented May 20, 2025

Copy link
Copy Markdown
Member

Adds "fullscreen" buttons to the videos in the cutting tab.

The goal is to give users a simple way to zoom in on a video in case they need to perceive details, like for example small text on a blackboard.

Bildschirmfoto vom 2025-05-20 10-49-34
Bildschirmfoto vom 2025-05-20 10-49-40

@Arnei Arnei added the type:usability Usability improvements label May 20, 2025
@Arnei Arnei marked this pull request as ready for review May 20, 2025 13:47
@github-actions

Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1585/2025-05-20_13-46-20/ .
It might take a few minutes for it to become available.

@gregorydlogan gregorydlogan changed the base branch from develop to r/17.x May 21, 2025 20:54
@Arnei

Arnei commented Jun 5, 2025

Copy link
Copy Markdown
Member Author

Seems like there are issues with Safari.

@Arnei

Arnei commented Jun 11, 2025

Copy link
Copy Markdown
Member Author

Safari issue should now be fixed.

@github-actions

Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1585/2025-06-11_08-59-03/ .
It might take a few minutes for it to become available.

@gregorydlogan

Copy link
Copy Markdown
Member

Is this the expected behaviour?

Screencast.from.2025-06-17.22-48-55.mp4

I feel like it's supposed to zoom in more?

@Arnei

Arnei commented Jun 18, 2025

Copy link
Copy Markdown
Member Author

That is not expected behaviour, it should roughly double in size. What browser are you testing with?

@snoesberger

Copy link
Copy Markdown
Contributor

I did some tests with videos from our test environment and I can confirm the behavior that Greg mentioned (with different browsers: Firefox, Chrome, Safari). Clicking the full-screen button barely enlarges the video. I think this is because the previews generated by the standard workflows are only 360 pixels high. The preview video used by the test deployment (the one with Lars) has a height of 720 pixels; therefore, the full-screen effect is larger with that video.
Ideally, we wouldn't use a fixed factor to resize the video, but rather use the available space. However, I don't know if this is easily feasible?

Additionally, the preview videos used for test.editor.opencast.org should be generated using the same encoding profiles as those used in standard Opencast workflows.

I also found another issue with the thumbnail view. The full-screen button is available there, too, but it doesn't work. And the thumbnail preview is completely broken in Safari:
grafik

Adds "fullscreen" buttons to the videos in the cutting tab.

The goal is to give users a simple way to zoom in on a video
in case they need to perceive details, like for example
small text on a blackboard.

TODO: Fullscreen button positioning
This was written by @ferishili, many thanks!

Fixes an issue where the video players would not show
up IN SAFARI, leaving small empty boxes in their place.
 Only after clicking the full screen button a few times would
 the videos then show up. This fixes the issue by toggling the
 fullscreen button ourselves via code. We also confine this
 toggling to Safari, so that people who use reasonable browsers
 are not affected by any brief visual glitches
 this may result in.
@Arnei Arnei changed the base branch from r/17.x to r/19.x December 17, 2025 13:40
@github-actions

github-actions Bot commented Dec 17, 2025

Copy link
Copy Markdown

This pull request is deployed at test.editor.opencast.org/1585/2026-04-20_12-45-56/ .
It might take a few minutes for it to become available.

@gregorydlogan

Copy link
Copy Markdown
Member

Still seeing the same behaviour I was seeing before the repoint. Testing with Chrome, though I see it in firefox as well.

@ferishili ferishili self-requested a review April 14, 2026 14:42
@ferishili ferishili self-assigned this Apr 14, 2026

@ferishili ferishili left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Arnei!

I tested this on the three major browsers on macOS (Safari 26.4, Firefox 149.0.2, and Chrome 147.0.7727.56), and it works great. ✅

One small improvement that would be nice to add: cursor: pointer; for the new button.

Also, there's an accessibility (A11y) aspect to consider for the new button. I'm not sure yet how far we want to go with that here, but it might be worth taking a quick look and try to introduce it on new elements.

@Arnei

Arnei commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

Hi @ferishili , thanks for testing!

I added cursor: pointer as you suggested. What accessibility aspect are you referring to? Or do you just mean we should generally think about how to make the fullscreen buttons properly accessible?

@ferishili

ferishili commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Great,
Regarding A11y, I'm not an expert, but for this kind of button an aria-label and an aria-pressed or somthing like that (to indicate whether it's toggled or not) should be sufficient so that screen readers can identify the state properly.

Also changed the icon to better reflect state.
@ferishili

Copy link
Copy Markdown
Contributor

Nice! Kudos for the awesome icons 👍✨

@gregorydlogan

Copy link
Copy Markdown
Member

I'm still seeing the same behaviour as I was before, regardless of test media. Same behaviour on Chrome and Firefox.

@gregorydlogan

Copy link
Copy Markdown
Member

I'm assuming this moves to 20+

@gregorydlogan gregorydlogan changed the base branch from r/19.x to r/20.x June 8, 2026 20:16
@github-actions github-actions Bot added the status:conflicts Conflicts with another pull request or issue label Jun 11, 2026
@github-actions

Copy link
Copy Markdown

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:conflicts Conflicts with another pull request or issue type:usability Usability improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants