Skip to content

Fix multi-select values in metadata not removable (Safari)#1496

Merged
gregorydlogan merged 1 commit into
opencast:r/19.xfrom
Arnei:safari-metadata-multiselect-removing-entries
Mar 15, 2026
Merged

Fix multi-select values in metadata not removable (Safari)#1496
gregorydlogan merged 1 commit into
opencast:r/19.xfrom
Arnei:safari-metadata-multiselect-removing-entries

Conversation

@Arnei

@Arnei Arnei commented Jan 5, 2026

Copy link
Copy Markdown
Member

Fixes a bug where values could not be removed from multi-select fields, like presenters or contributors in the event metadata. When clicking on the "X" of the blue box with the value, the field would leave edit mode but the value was not removed. This is due to a timing issue most notable in Safari. This patch fixes the issue by making the field not leave edit mode when clicking on "X", which is how multi-select fields behaved in 18.x as well.

This fix has an unpleasant side effect, where multi-select fields will not properly blur anymore when left via tab navigation. I am not sure how to properly fix this with the current code.

Fixes a bug where values could not be removed from
multi-select fields, like presenters or contributors in the event
metadata. When clicking on the "X" of the blue box with
the value, the field would leave edit mode but the value
was not removed.

This fix has an unpleasant side effect, where multi-select fields
will not properly blur anymore when left via tab navigation.
I am not sure how to properly fix this with the current code.
@Arnei Arnei added the type:bug Something isn't working label Jan 5, 2026
@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1496

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1496

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions

github-actions Bot commented Jan 5, 2026

Copy link
Copy Markdown
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1496/2026-01-05_11-52-27/ .
It might take a few minutes for it to become available.

@gregorydlogan

Copy link
Copy Markdown
Member

This doesn't break anything obvious to me, but I don't have a Mac to test with. @mtneug @karendolan @rute-santos @snoesberger I think you're all on macs. There's a test above, don't even have to build anything.

@snoesberger

Copy link
Copy Markdown
Contributor

I did a quick test on my Mac using Safari. I can now successfully remove values from the multi-select fields. I also successfully tested this with Firefox and Chrome.

But I had to use the docker image to test this. test.admin-interface.opencast.org/1496/2026-01-05_11-52-27/ doesn't allow me to change metadata because of CORS policy:

Access to XMLHttpRequest at 'https://develop.opencast.org/admin-ng/event/ID-portrait/metadata' from origin 'https://test.admin-interface.opencast.org' has been blocked by CORS policy: Method PUT is not allowed by Access-Control-Allow-Methods in preflight response

It would be nice if the CORS policy could be adapted to allow such tests.

@gregorydlogan gregorydlogan self-assigned this Mar 15, 2026
@gregorydlogan gregorydlogan merged commit 3054896 into opencast:r/19.x Mar 15, 2026
9 checks passed
@gregorydlogan

Copy link
Copy Markdown
Member

Thanks @snoesberger. I've filed an issue to track the CORS stuff!

jduehring pushed a commit to jduehring/opencast-admin-interface that referenced this pull request Apr 16, 2026
…opencast-admin-interface into r/19.x

Pull request opencast#1496

  Fix multi-select values in metadata not removable (Safari)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants