Conversation
|
I have tested extracting features on both mouse and human data with this new reader and the output looked decent. |
darshanmandge
left a comment
darshanmandge
left a comment
There was a problem hiding this comment.
Thanks @AurelienJaquier!
Can you add more description to the PR?
bluepyefe/nwbreader.py
Outdated
|
|
||
| def __init__(self, content, target_protocols, in_data, repetition=None): | ||
| """ Init | ||
| Args: |
There was a problem hiding this comment.
Can you please add a comment here referring to the dataset + first author, paper name and DOI?
| i_unit = current.attrs["unit"].decode('UTF-8') | ||
| t_unit = start_time.attrs["unit"].decode('UTF-8') | ||
|
|
||
| if ( |
There was a problem hiding this comment.
Looks like this logic will be only used by one dataset which will use this reader. The _format_nwb_trace is being used by all the NWB readers. @ilkilic do you think we can instead update the data?
There was a problem hiding this comment.
I agree, it would be better to clean the data directly
There was a problem hiding this comment.
But then if someone tries to use BPE directly on the data straight from the source, they won't be able to read them
There was a problem hiding this comment.
I think users can use the data downloaded from OBI directly, as it will be cleaner and easier to understand. :)
There was a problem hiding this comment.
As we are busy with other tasks, we can use the nwb files in the original format. I will create a task to edit these files to make them simple.
3 participants
10.48324/dandi.000293/0.220708.1652 (human), and
10.48324/dandi.000292/0.220708.1652 (mouse).