Skip to content

conform to latest libsonata#70

Merged
AurelienJaquier merged 2 commits intomainfrom
libsonata-quickfix
Mar 12, 2026
Merged

conform to latest libsonata#70
AurelienJaquier merged 2 commits intomainfrom
libsonata-quickfix

Conversation

@AurelienJaquier
Copy link
Collaborator

because new libsonata dependencies has some restrictions about the SEClamp input

the behavior is not changed because the last voltage step lasts until the seclamp is off, independently of the duration given

@AurelienJaquier
Copy link
Collaborator Author

Also will have to change

 if len(voltages) != len(durations) - 1:
        msg = "Invalid SEClamp config: len(voltage_levels) must equal len(duration_levels) - 1"
        raise ValueError(msg)

into

  if len(voltages) != len(durations):
        msg = "Invalid SEClamp config: len(voltage_levels) must equal len(duration_levels)"
        raise ValueError(msg)

in openbraininstitute/Bluenaas#124 when this PR and openbraininstitute/obi-one#627 are merged

@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
bluecellulab/cell/injector.py 94.21% <100.00%> (ø)
tests/test_cell/test_injector.py 98.72% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AurelienJaquier AurelienJaquier requested a review from ilkilic March 12, 2026 16:20
@AurelienJaquier AurelienJaquier merged commit 56ba687 into main Mar 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants