Unify report writing across single-rank and MPI runs using recording sites#65
Merged
Unify report writing across single-rank and MPI runs using recording sites#65
Conversation
Collaborator
darshanmandge
left a comment
There was a problem hiding this comment.
Thanks! I have made some comments.
AurelienJaquier
approved these changes
Mar 11, 2026
Collaborator
AurelienJaquier
left a comment
There was a problem hiding this comment.
looks good, thanks a lot!
darshanmandge
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors report writing to operate on cell recordings instead of voltage trace dictionaries. Reports are now generated from configured recording sites, unifying single-rank and MPI workflows and making compartment reports consistent with the NEURON recording model.
What changed
cell.report_sites[report_name].
and write reports there.
The cells argument must be a mapping {CellId: cell-like} where entries expose:
Why
The previous pipeline supported multiple input shapes (live cells vs gathered trace
dictionaries). This made behavior harder to reason about and fragile, especially for
non-voltage variables and MPI execution.
The new pipeline separates responsibilities:
1. recording configuration
2. simulation
3. gathering
4. writing
MPI usage (Recommended)
Consumers running under MPI should gather locally recorded data and write only on rank 0:
This replaces the previous approach where users gathered trace dicts and passed cells_or_traces=traces.
Non-MPI usage
Single-rank usage remains simple:
Any consumer code passing cells_or_traces or trace dictionaries must migrate to:
• cells=sim.cells (single rank), or
• cells=payload_to_cells(...) on rank 0 after MPI gather.