Repository navigation
Preserve result columns named index in to_dict - #7784
Closed
rudycelekli wants to merge 1 commit into
Closed
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OBBject.to_dict preserves genuine result columns named index, avoiding silent data loss in table results. The previous test that fabricated an index column by replacing to_dataframe is replaced with a native DataFrame conversion regression.
How has this been tested?
ae0268771f76and pass with this change.69 passed in 1.03s.git diff --checkpass.Full provider integrations were not run.
Additional compatibility checks: the combined production changes pass the full core suite (2,270 tests, 36 skipped, 184 subtests). The canonical CLI suite passes 2,241 tests with one existing backend test failure reproduced on unchanged develop. Individual native regression and adjacent tests pass; changed production files and new regression tests pass Ruff and ty. Existing OpenAPI test typing diagnostics also reproduce on unchanged develop. No live data-provider integrations were exercised.