Skip to content

Preserve result columns named index in to_dict - #7784

Closed
rudycelekli wants to merge 1 commit into
openbq-org:developfrom
rudycelekli:hotfix/preserve-named-index-result-column
Closed

rudycelekli wants to merge 1 commit into
openbq-org:developfrom
rudycelekli:hotfix/preserve-named-index-result-column

Conversation

@rudycelekli

Copy link
Copy Markdown

Description

OBBject.to_dict preserves genuine result columns named index, avoiding silent data loss in table results. The previous test that fabricated an index column by replacing to_dataframe is replaced with a native DataFrame conversion regression.

How has this been tested?

  • Added native regression tests that fail against develop ae0268771f76 and pass with this change.
  • Ran the regression and adjacent repository tests: 69 passed in 1.03s.
  • Ruff lint/format and git diff --check pass.
  • Tests use repository source with declared dependencies and isolated temporary settings; no live provider credentials or data services.

Full provider integrations were not run.

Additional compatibility checks: the combined production changes pass the full core suite (2,270 tests, 36 skipped, 184 subtests). The canonical CLI suite passes 2,241 tests with one existing backend test failure reproduced on unchanged develop. Individual native regression and adjacent tests pass; changed production files and new regression tests pass Ruff and ty. Existing OpenAPI test typing diagnostics also reproduce on unchanged develop. No live data-provider integrations were exercised.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants