Repository navigation
Conversation
When the maturity filter left no series, the fetcher asked FRED for an empty symbol list, and when no observations came back, melt(id_vars="date") raised KeyError: 'date' (500). FRED publishes no live 5-year TIPS (every 5-year series in release 72 is marked DISCONTINUED and filtered out), so maturity=5 always hit this. Both cases now raise EmptyDataError. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Hi @artcashin, thanks for the PR. The correct solution here is to remove the choice that is no longer valid and not have any workaround logic. |
Address review: FRED no longer publishes a live 5-year TIPS (every 5-year series in release 72 is discontinued), so remove the choice instead of guarding the empty result it produced. The recorded fetcher test now asks for the 10-year maturity, re-recorded against FRED. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
artcashin
changed the title
Author
|
Thanks, done in a9dac40. The |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
fixedincome.government.tips_yields(providerfred) offeredmaturity=5. FRED no longer publishes a live 5-year TIPS: every 5-year series in release 72 is marked DISCONTINUED and filtered out. So that choice always sent an empty symbol list to the series fetcher and failed withKeyError: 'date'.Change
"5"from thematuritychoices. The remaining choices are 10, 20 and 30.Tests
test_fred_tips_yields_fetchernow requests the 10-year maturity. Its cassette was re-recorded against FRED, with the API key filtered toMOCK_API_KEY.develop.🤖 Generated with Claude Code