Skip to content

chore(api): clarify image fidelity and legacy image guidance - #730

Closed
markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-130
Closed

markstuart-oai wants to merge 1 commit into
mainfrom
castiron/promotions/pr-130

Conversation

@markstuart-oai

@markstuart-oai markstuart-oai commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Clarifies image fidelity guidance for image edits and image tools: the low default applies to models that support the parameter, mini retains its low-only exception, and unsupported models require omission. Identifies retired DALL·E settings and variations as legacy, and directs callers to supported image workflows with an explicit model choice.

No Ruby runtime behavior, signatures, enums, defaults, nullability, serialization, or exported names change.

Validation: the Ruby 3.3/3.4/4.0 test matrix, Bedrock tests, lint, RBI type checks, RBS validation and package checks pass. Token comparison confirms all Ruby and signature changes are documentation-only.

Source monorepo PR: #1488175.

@github-actions

github-actions Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Castiron custom code

✅ No new custom-code files detected.

70 mixed files remain; 0 existing customizations changed; 1 generated baselines changed.

Compared 475318f0815233f9e9c24fe6. Generated baselines verified.

File Result Current custom patch
lib/openai/models/responses/tool.rb Generated baseline changed +2 / −0
69 existing customizations unchanged
  • lib/openai.rb
  • lib/openai/client.rb
  • lib/openai/models/audio/transcription_create_response.rb
  • lib/openai/models/beta/agents/vault_status_filter.rb
  • lib/openai/models/chat/chat_completion_message.rb
  • lib/openai/models/chat/chat_completion_message_function_tool_call.rb
  • lib/openai/models/chat/completion_create_params.rb
  • lib/openai/models/image_edit_completed_event.rb
  • lib/openai/models/image_edit_partial_image_event.rb
  • lib/openai/models/image_gen_completed_event.rb
  • lib/openai/models/image_gen_partial_image_event.rb
  • lib/openai/models/images_response.rb
  • lib/openai/models/response_format_json_schema.rb
  • lib/openai/models/responses/function_tool.rb
  • lib/openai/models/responses/response.rb
  • lib/openai/models/responses/response_create_params.rb
  • lib/openai/models/responses/response_format_text_config.rb
  • lib/openai/models/responses/response_format_text_json_schema_config.rb
  • lib/openai/models/responses/response_function_tool_call.rb
  • lib/openai/models/responses/response_function_web_search.rb
  • lib/openai/models/responses/response_output_text.rb
  • lib/openai/models/webhooks/webhook_endpoint_with_secret.rb
  • lib/openai/resources/beta/agents/sessions.rb
  • lib/openai/resources/beta/threads.rb
  • lib/openai/resources/chat/completions.rb
  • lib/openai/resources/containers/files.rb
  • lib/openai/resources/files.rb
  • lib/openai/resources/responses.rb
  • lib/openai/resources/vector_stores/file_batches.rb
  • lib/openai/resources/vector_stores/files.rb
  • lib/openai/resources/webhooks.rb
  • rbi/openai/client.rbi
  • rbi/openai/models/beta/agents/vault_status_filter.rbi
  • rbi/openai/models/chat/chat_completion_message.rbi
  • rbi/openai/models/chat/chat_completion_message_function_tool_call.rbi
  • rbi/openai/models/chat/completion_create_params.rbi
  • rbi/openai/models/image_edit_completed_event.rbi
  • rbi/openai/models/image_edit_partial_image_event.rbi
  • rbi/openai/models/image_gen_completed_event.rbi
  • rbi/openai/models/image_gen_partial_image_event.rbi

29 more in the full report.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 35691179249 --repo openai/openai-ruby \
  --name castiron-custom-code-35691179249-1 --dir /tmp/castiron-custom-code-35691179249-1
git apply --stat /tmp/castiron-custom-code-35691179249-1/custom-code.patch
cat /tmp/castiron-custom-code-35691179249-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 475318f0815207cbe1beee8f4d6839dd92870dba 33f9e9c24fe631eaf7f3b4436c3b8eab0e7ac5c4
python3 scripts/castiron/custom_code_report.py report \
  --base 475318f0815207cbe1beee8f4d6839dd92870dba \
  --head 33f9e9c24fe631eaf7f3b4436c3b8eab0e7ac5c4 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-33f9e9c24fe6
cat /tmp/castiron-custom-code-33f9e9c24fe6/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-22T05:34:43.059792Z 33f9e9c New commits
🔒 Security Review Completed 2026-09-22T05:36:00.108907Z 33f9e9c New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: 2306a54774

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 2306a54774

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@markstuart-oai
markstuart-oai marked this pull request as ready for review September 21, 2026 01:07
@markstuart-oai
markstuart-oai requested a review from a team as a code owner September 21, 2026 01:07
@openai-sdks

openai-sdks Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

🟡 Running for Ruby SDK PR #730.

View OkTest run #35691153906

SDK merge (pending) · head (33f9e9c24fe6) · base (475318f08152) · OkTest (a0be4375e02d)

@markstuart-oai
markstuart-oai force-pushed the castiron/promotions/pr-130 branch from 2306a54 to ccd88da Compare September 21, 2026 05:56
@markstuart-oai
markstuart-oai requested a review from a team September 21, 2026 06:07
Castiron-Internal-PR: openai/openai-ruby-internal#130
Castiron-Source-SHA: 7fe3843811062511aa3008dc6006d45ca360f083
Castiron-Public-Base-SHA: 475318f
@jbeckwith-oai
jbeckwith-oai force-pushed the castiron/promotions/pr-130 branch from ccd88da to 33f9e9c Compare September 22, 2026 05:33
@markstuart-oai
markstuart-oai marked this pull request as draft September 22, 2026 05:35
auto-merge was automatically disabled September 22, 2026 05:35

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants